Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/desks/controllers/DeskConfigController.ts

Summary

Maintainability
C
1 day
Test Coverage

Function DeskConfigController has 105 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function DeskConfigController($scope, $controller, notify, desks, modal) {
    // expecting $scope.desks to be defined

    $scope.modalActive = false;
    $scope.numberOfUsers = 3;
Severity: Major
Found in scripts/apps/desks/controllers/DeskConfigController.ts - About 4 hrs to fix

    Function DeskConfigController has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

    export function DeskConfigController($scope, $controller, notify, desks, modal) {
    // expecting $scope.desks to be defined

    $scope.modalActive = false;
    $scope.numberOfUsers = 3;
    Severity: Minor
    Found in scripts/apps/desks/controllers/DeskConfigController.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function DeskConfigController has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    export function DeskConfigController($scope, $controller, notify, desks, modal) {
    Severity: Minor
    Found in scripts/apps/desks/controllers/DeskConfigController.ts - About 35 mins to fix

      Function calculateDiff has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export function calculateDiff(editObj, origObj) {
    let diff = generate(origObj, editObj) || {};

    for (const key in diff) {
        if (diff[key] === null && editObj[key] !== null) {
      Severity: Minor
      Found in scripts/apps/desks/controllers/DeskConfigController.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status