Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/ingest/directives/IngestRoutingContent.ts

Summary

Maintainability
D
2 days
Test Coverage

Function IngestRoutingContent has 135 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function IngestRoutingContent(api, notify, modal, contentFilters, $filter) {
    return {
        templateUrl: 'scripts/apps/ingest/views/settings/ingest-routing-content.html',
        link: function(scope) {
            let _orig = null, _origRule = null, _new = false;
Severity: Major
Found in scripts/apps/ingest/directives/IngestRoutingContent.ts - About 5 hrs to fix

    Function link has 130 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            link: function(scope) {
            let _orig = null, _origRule = null, _new = false;

            scope.editScheme = null;
            scope.selectedRule = null;
    Severity: Major
    Found in scripts/apps/ingest/directives/IngestRoutingContent.ts - About 5 hrs to fix

      Function IngestRoutingContent has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      export function IngestRoutingContent(api, notify, modal, contentFilters, $filter) {
    return {
        templateUrl: 'scripts/apps/ingest/views/settings/ingest-routing-content.html',
        link: function(scope) {
            let _orig = null, _origRule = null, _new = false;
      Severity: Minor
      Found in scripts/apps/ingest/directives/IngestRoutingContent.ts - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function IngestRoutingContent has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export function IngestRoutingContent(api, notify, modal, contentFilters, $filter) {
      Severity: Minor
      Found in scripts/apps/ingest/directives/IngestRoutingContent.ts - About 35 mins to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                        api('routing_schemes').query({max_results: 200})
                    .then((result) => {
                        scope.schemes = $filter('sortByName')(result._items);
                    });
        Severity: Major
        Found in scripts/apps/ingest/directives/IngestRoutingContent.ts and 3 other locations - About 1 hr to fix
        scripts/apps/ingest/directives/IngestRulesContent.ts on lines 13..16
        scripts/apps/ingest/directives/IngestSourcesContent.ts on lines 216..219
        scripts/apps/ingest/directives/IngestSourcesContent.ts on lines 221..224

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    scope.reorder = (start, end) => {
                scope.editScheme.rules.splice(end, 0, scope.editScheme.rules.splice(start, 1)[0]);
            };
        Severity: Minor
        Found in scripts/apps/ingest/directives/IngestRoutingContent.ts and 1 other location - About 35 mins to fix
        scripts/apps/ingest/directives/IngestRulesContent.ts on lines 75..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status