Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/monitoring/controllers/AggregateCtrl.ts

Summary

Maintainability
F
5 days
Test Coverage

Function AggregateCtrl has 433 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function AggregateCtrl($scope, desks, workspaces, preferencesService, storage,
    savedSearch, content) {
    const CONTENT_PROLFILE = gettext('Content profile');
    var PREFERENCES_KEY = 'agg:view';
    var defaultMaxItems = 10;
Severity: Major
Found in scripts/apps/monitoring/controllers/AggregateCtrl.ts - About 2 days to fix

    Function AggregateCtrl has a Cognitive Complexity of 90 (exceeds 5 allowed). Consider refactoring.
    Open

    export function AggregateCtrl($scope, desks, workspaces, preferencesService, storage,
    savedSearch, content) {
    const CONTENT_PROLFILE = gettext('Content profile');
    var PREFERENCES_KEY = 'agg:view';
    var defaultMaxItems = 10;
    Severity: Minor
    Found in scripts/apps/monitoring/controllers/AggregateCtrl.ts - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File AggregateCtrl.ts has 445 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {each, forEach, isNil, partition, keyBy} from 'lodash';
import {gettext, getItemTypes} from 'core/utils';
import {SCHEDULED_OUTPUT, DESK_OUTPUT} from 'apps/desks/constants';
import {appConfig} from 'appConfig';
import {IMonitoringFilter, IStage, IDesk, IMonitoringGroup} from 'superdesk-api';
    Severity: Minor
    Found in scripts/apps/monitoring/controllers/AggregateCtrl.ts - About 6 hrs to fix

      Function edit has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          this.edit = function(currentStep, displayOnlyCurrentStep) {
        this.editGroups = {};

        this.refreshGroups().then(() => {
            var _groups = this.groups;
      Severity: Minor
      Found in scripts/apps/monitoring/controllers/AggregateCtrl.ts - About 1 hr to fix

        Function initSpikeGroups has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function initSpikeGroups(isDesk) {
        var spikeDesks: any = {};

        if (self.spikeGroups.length > 0) {
            self.spikeGroups.length = 0;
        Severity: Minor
        Found in scripts/apps/monitoring/controllers/AggregateCtrl.ts - About 1 hr to fix

          Function setFilterType has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              this.setFilterType = function(filterType, filterValue, $event?) {
        if (filterType === 'contentProfile') {
            if (!this.activeFilters.contentProfile.includes(filterValue._id)) {
                this.activeFilters.contentProfile.push(filterValue._id);
                const tag = {'key': filterValue._id, 'label': gettext(filterValue.label)};
          Severity: Minor
          Found in scripts/apps/monitoring/controllers/AggregateCtrl.ts - About 1 hr to fix

            Function AggregateCtrl has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            export function AggregateCtrl($scope, desks, workspaces, preferencesService, storage,
    savedSearch, content) {
            Severity: Major
            Found in scripts/apps/monitoring/controllers/AggregateCtrl.ts - About 50 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  this.getSelectedFileTypes = function(): string {
        return this.activeFilters.fileType.length === 0 ? null : JSON.stringify(this.activeFilters.fileType);
    };
              Severity: Major
              Found in scripts/apps/monitoring/controllers/AggregateCtrl.ts and 1 other location - About 1 hr to fix
              scripts/apps/monitoring/controllers/AggregateCtrl.ts on lines 372..375

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  this.getSelectedContentProfiles = function(): string {
        return this.activeFilters.contentProfile.length === 0 ? null
            : JSON.stringify(this.activeFilters.contentProfile);
    };
              Severity: Major
              Found in scripts/apps/monitoring/controllers/AggregateCtrl.ts and 1 other location - About 1 hr to fix
              scripts/apps/monitoring/controllers/AggregateCtrl.ts on lines 368..370

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          } else if (desks.isOutputType(card.type)) {
                var deskId = card._id.substring(0, card._id.indexOf(':'));

                card.header = self.deskLookup[deskId].name;
            } else if (card.type === 'search') {
              Severity: Major
              Found in scripts/apps/monitoring/controllers/AggregateCtrl.ts and 1 other location - About 1 hr to fix
              scripts/apps/monitoring/directives/AggregateSettings.ts on lines 256..260

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 59.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              if (widget.configuration && self.widget._id === widget._id
                    && self.widget.multiple_id === widget.multiple_id) {
                    groups = widget.configuration.groups || groups;
                    self.widget.configuration.label = widget.configuration.label || '';
                }
              Severity: Minor
              Found in scripts/apps/monitoring/controllers/AggregateCtrl.ts and 1 other location - About 35 mins to fix
              scripts/apps/desks/services/DesksFactory.ts on lines 84..87

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status