Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/monitoring/controllers/MonitoringController.ts

Summary

Maintainability
C
1 day
Test Coverage

Function MonitoringController has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

export function MonitoringController($rootScope, $scope, $location, desks, superdeskFlags,
    search, $filter, preferencesService, $q) {
    this.state = {};

    this.preview = preview;
Severity: Minor
Found in scripts/apps/monitoring/controllers/MonitoringController.ts - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function MonitoringController has 113 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function MonitoringController($rootScope, $scope, $location, desks, superdeskFlags,
    search, $filter, preferencesService, $q) {
    this.state = {};

    this.preview = preview;
Severity: Major
Found in scripts/apps/monitoring/controllers/MonitoringController.ts - About 4 hrs to fix

    Function MonitoringController has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    export function MonitoringController($rootScope, $scope, $location, desks, superdeskFlags,
    search, $filter, preferencesService, $q) {
    Severity: Major
    Found in scripts/apps/monitoring/controllers/MonitoringController.ts - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status