Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/monitoring/directives/MonitoringGroup.ts

Summary

Maintainability
F
1 wk
Test Coverage

Function MonitoringGroup has a Cognitive Complexity of 139 (exceeds 5 allowed). Consider refactoring.
Open

export function MonitoringGroup(
    cards,
    api,
    authoringWorkspace: AuthoringWorkspaceService,
    $timeout,
Severity: Minor
Found in scripts/apps/monitoring/directives/MonitoringGroup.ts - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function MonitoringGroup has 483 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function MonitoringGroup(
    cards,
    api,
    authoringWorkspace: AuthoringWorkspaceService,
    $timeout,
Severity: Major
Found in scripts/apps/monitoring/directives/MonitoringGroup.ts - About 2 days to fix

    Function link has 462 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            link: function(scope: IScope, elem, attrs, ctrls) {
            if (scope.group == null) {
                scope.group = {};
            }
    Severity: Major
    Found in scripts/apps/monitoring/directives/MonitoringGroup.ts - About 2 days to fix

      File MonitoringGroup.ts has 575 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* eslint-disable complexity */
import _, {debounce} from 'lodash';
import getCustomSortForGroup, {GroupSortOptions} from '../helpers/CustomSortOfGroups';
import {GET_LABEL_MAP, getLabelForStage} from '../../workspace/content/constants';
import {isPublished} from 'apps/archive/utils';
      Severity: Major
      Found in scripts/apps/monitoring/directives/MonitoringGroup.ts - About 1 day to fix

        Function queryItems has 90 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    function queryItems(event?, data?, params?) {
                var originalQuery;

                if (desks.changeDesk) {
                    desks.changeDesk = false;
        Severity: Major
        Found in scripts/apps/monitoring/directives/MonitoringGroup.ts - About 3 hrs to fix

          Function MonitoringGroup has 11 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              cards,
    api,
    authoringWorkspace: AuthoringWorkspaceService,
    $timeout,
    superdesk,
          Severity: Major
          Found in scripts/apps/monitoring/directives/MonitoringGroup.ts - About 1 hr to fix

            Function scheduleIfShouldUpdate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                        function scheduleIfShouldUpdate(event, data) {
                if (data && data.from_stage && data.from_stage === scope.group._id) {
                    // item was moved from current stage
                    extendItem(data.item, {
                        gone: true,
            Severity: Minor
            Found in scripts/apps/monitoring/directives/MonitoringGroup.ts - About 1 hr to fix

              Function preview has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                          function preview(item) {
                if (item) {
                    // for items from external source or if type is undefined.
                    if (item._type === 'externalsource') {
                        select(item);
              Severity: Minor
              Found in scripts/apps/monitoring/directives/MonitoringGroup.ts - About 1 hr to fix

                Consider simplifying this complex logical expression.
                Open

                                        if (data && (data.item || data.items || data.item_id) && scope.showRefresh && !data.force) {
                            // if we know the ids of the items then try to fetch those only
                            originalQuery = angular.extend({}, criteria.source.query);

                            let items = data.items || {};
                Severity: Major
                Found in scripts/apps/monitoring/directives/MonitoringGroup.ts - About 1 hr to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              function extendItem(itemId, updates) {
                scope.$apply(() => {
                    scope.items._items = scope.items._items.map((item) => {
                        if (item._id === itemId) {
                            return angular.extend(item, updates);
                  Severity: Major
                  Found in scripts/apps/monitoring/directives/MonitoringGroup.ts and 1 other location - About 4 hrs to fix
                  scripts/apps/search/directives/SearchResults.ts on lines 319..331

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 120.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              scope.$on('view:column', (_event, data) => {
                scope.$applyAsync(() => {
                    scope.viewColumn = data.viewColumn;
                });
            });
                  Severity: Minor
                  Found in scripts/apps/monitoring/directives/MonitoringGroup.ts and 1 other location - About 40 mins to fix
                  scripts/apps/dictionaries/controllers/DictionaryEditController.ts on lines 34..38

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 49.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              scope.$watch('selected', (newVal, oldVal) => {
                if (!newVal && scope.previewingBroadcast) {
                    scope.previewingBroadcast = false;
                }
            });
                  Severity: Minor
                  Found in scripts/apps/monitoring/directives/MonitoringGroup.ts and 1 other location - About 35 mins to fix
                  scripts/apps/search/directives/SearchResults.ts on lines 191..195

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status