Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/monitoring/services/CardsService.ts

Summary

Maintainability
F
3 days
Test Coverage

Function CardsService has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
Open

export function CardsService(search, session, desks, $location) {
    this.criteria = getCriteria;
    this.shouldUpdate = shouldUpdate;

    function getCriteriaParams(card: ICard): IQueryParams {
Severity: Minor
Found in scripts/apps/monitoring/services/CardsService.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function CardsService has 202 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function CardsService(search, session, desks, $location) {
    this.criteria = getCriteria;
    this.shouldUpdate = shouldUpdate;

    function getCriteriaParams(card: ICard): IQueryParams {
Severity: Major
Found in scripts/apps/monitoring/services/CardsService.ts - About 1 day to fix

    Function filterQueryByCardType has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function filterQueryByCardType(query, queryParam, card: ICard) {
        let deskId;
        const extensionSection = getExtensionSections();
        const section = extensionSection.find((response) => response.id === card.type);
    Severity: Major
    Found in scripts/apps/monitoring/services/CardsService.ts - About 2 hrs to fix

      File CardsService.ts has 257 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import {flatMap, flattenDeep, includes, isNil} from 'lodash';
import {setFilters, IQueryParams} from 'apps/search/services/SearchService';
import {PUBLISHED_STATES} from 'apps/archive/constants';
import {ITEM_STATE} from 'apps/archive/constants';
import {
      Severity: Minor
      Found in scripts/apps/monitoring/services/CardsService.ts - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                Object.keys(terms).forEach((key) => {
            query.filter({terms: {[key]: terms[key]}});
        });
        Severity: Minor
        Found in scripts/apps/monitoring/services/CardsService.ts and 1 other location - About 50 mins to fix
        scripts/apps/search/services/SearchService.ts on lines 519..521

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                if (card.contentProfile) {
            query.filter({terms: {profile: JSON.parse(card.contentProfile)}});
        }
        Severity: Major
        Found in scripts/apps/monitoring/services/CardsService.ts and 3 other locations - About 35 mins to fix
        scripts/apps/search/services/SearchService.ts on lines 417..419
        scripts/apps/search/services/SearchService.ts on lines 421..423
        scripts/apps/search/services/SearchService.ts on lines 454..456

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status