Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/packaging/directives/PackageItemPreview.ts

Summary

Maintainability
C
1 day
Test Coverage

Function PackageItemPreview has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function PackageItemPreview(api, lock, superdesk, authoringWorkspace: AuthoringWorkspaceService, $sce,
    desks, vocabularies) {
    return {
        scope: {
            item: '=',
Severity: Major
Found in scripts/apps/packaging/directives/PackageItemPreview.ts - About 3 hrs to fix

    Function link has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            link: function(scope, elem) {
            scope.data = null;
            scope.error = null;
            scope.userLookup = desks.userLookup;
            scope.label = null;
    Severity: Major
    Found in scripts/apps/packaging/directives/PackageItemPreview.ts - About 3 hrs to fix

      Function PackageItemPreview has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      export function PackageItemPreview(api, lock, superdesk, authoringWorkspace: AuthoringWorkspaceService, $sce,
    desks, vocabularies) {
    return {
        scope: {
            item: '=',
      Severity: Minor
      Found in scripts/apps/packaging/directives/PackageItemPreview.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function PackageItemPreview has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export function PackageItemPreview(api, lock, superdesk, authoringWorkspace: AuthoringWorkspaceService, $sce,
    desks, vocabularies) {
      Severity: Major
      Found in scripts/apps/packaging/directives/PackageItemPreview.ts - About 50 mins to fix

        There are no issues that match your filters.

        Category
        Status