Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/publish/directives/SubscribersDirective.ts

Summary

Maintainability
D
2 days
Test Coverage

Function SubscribersDirective has 177 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function SubscribersDirective(
    notify, api, subscribersService, adminPublishSettingsService,
    modal, contentFilters, $q, $filter, products, $rootScope,
) {
    return {
Severity: Major
Found in scripts/apps/publish/directives/SubscribersDirective.ts - About 7 hrs to fix

    Function link has 168 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            link: function($scope) {
            $scope.subscriber = null;
            $scope.origSubscriber = null;
            $scope.subscribers = $scope.subscribersList || null;
            $scope.newDestination = null;
    Severity: Major
    Found in scripts/apps/publish/directives/SubscribersDirective.ts - About 6 hrs to fix

      Function SubscribersDirective has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      export function SubscribersDirective(
    notify, api, subscribersService, adminPublishSettingsService,
    modal, contentFilters, $q, $filter, products, $rootScope,
) {
    return {
      Severity: Minor
      Found in scripts/apps/publish/directives/SubscribersDirective.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function save has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  $scope.save = function() {
                $scope.subscriber.destinations = $scope.destinations;

                let diff = {};
      Severity: Minor
      Found in scripts/apps/publish/directives/SubscribersDirective.ts - About 1 hr to fix

        Function SubscribersDirective has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            notify, api, subscribersService, adminPublishSettingsService,
    modal, contentFilters, $q, $filter, products, $rootScope,
        Severity: Major
        Found in scripts/apps/publish/directives/SubscribersDirective.ts - About 1 hr to fix

          Function edit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      $scope.edit = function(subscriber) {
                let promises = [];

                promises.push(fetchPublishErrors());
                promises.push(fetchProducts());
          Severity: Minor
          Found in scripts/apps/publish/directives/SubscribersDirective.ts - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        $scope.subTypes = [
                {name: gettext('All'), qcode: 'all'},
                {name: gettext('Digital/Internet'), qcode: 'digital'},
                {name: gettext('Wire/Paper'), qcode: 'wire'},
            ];
            Severity: Major
            Found in scripts/apps/publish/directives/SubscribersDirective.ts and 1 other location - About 1 hr to fix
            scripts/apps/ingest/directives/IngestSourcesContent.ts on lines 137..141

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                            } else if (angular.isDefined(response.data._issues.name) &&
                                    angular.isDefined(response.data._issues.name.unique)) {
                                    notify.error(gettext('Error: Subscriber with Name ' + $scope.subscriber.name +
                                        ' already exists.'));
                                } else if (angular.isDefined(response.data._issues.destinations)) {
            Severity: Minor
            Found in scripts/apps/publish/directives/SubscribersDirective.ts and 1 other location - About 45 mins to fix
            scripts/apps/search-providers/directive.ts on lines 60..64

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status