Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/relations/directives/RelatedItemsDirective.ts

Summary

Maintainability
F
3 days
Test Coverage

Function RelatedItemsDirective has 218 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function RelatedItemsDirective(
    authoringWorkspace: AuthoringWorkspaceService,
    relationsService,
    notify,
    lock,
Severity: Major
Found in scripts/apps/relations/directives/RelatedItemsDirective.ts - About 1 day to fix

    Function link has 207 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            link: function(scope: IScope, elem, attr) {
            scope.onCreated = (items: Array<IArticle>) => {
                items.forEach((item) => {
                    scope.addRelatedItem(item);
                    storage.setItem(`open-item-after-related-closed--${item._id}`, scope.item._id);
    Severity: Major
    Found in scripts/apps/relations/directives/RelatedItemsDirective.ts - About 1 day to fix

      Function RelatedItemsDirective has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
      Open

      export function RelatedItemsDirective(
    authoringWorkspace: AuthoringWorkspaceService,
    relationsService,
    notify,
    lock,
      Severity: Minor
      Found in scripts/apps/relations/directives/RelatedItemsDirective.ts - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File RelatedItemsDirective.ts has 267 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import {gettext} from 'core/utils';
import {AuthoringWorkspaceService} from 'apps/authoring/authoring/services/AuthoringWorkspaceService';
import {IArticle, IVocabulary, IRendition} from 'superdesk-api';
import {IDirectiveScope} from 'types/Angular/DirectiveScope';
import {getAssociationsByFieldId} from '../../authoring/authoring/controllers/AssociationController';
      Severity: Minor
      Found in scripts/apps/relations/directives/RelatedItemsDirective.ts - About 2 hrs to fix

        Function RelatedItemsDirective has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            authoringWorkspace: AuthoringWorkspaceService,
    relationsService,
    notify,
    lock,
    $rootScope,
        Severity: Major
        Found in scripts/apps/relations/directives/RelatedItemsDirective.ts - About 50 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      const addDragOverClass = () => {
                elem.find('.item-association').addClass(dragOverClass);
                elem.find('.related-items').addClass(dragOverClass);
            };
          Severity: Minor
          Found in scripts/apps/relations/directives/RelatedItemsDirective.ts and 1 other location - About 45 mins to fix
          scripts/apps/authoring/authoring/directives/ItemAssociationDirective.ts on lines 98..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          const maxCount = scope.field?.field_options?.multiple_items?.enabled === true
                    ? scope.field.field_options.multiple_items.max_items
                    : 1;
          Severity: Minor
          Found in scripts/apps/relations/directives/RelatedItemsDirective.ts and 1 other location - About 40 mins to fix
          scripts/apps/relations/directives/RelatedItemsDirective.ts on lines 127..129

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              const maxCount = scope.field?.field_options?.multiple_items?.enabled === true
                        ? scope.field.field_options.multiple_items.max_items
                        : 1;
          Severity: Minor
          Found in scripts/apps/relations/directives/RelatedItemsDirective.ts and 1 other location - About 40 mins to fix
          scripts/apps/relations/directives/RelatedItemsDirective.ts on lines 87..89

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status