Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/search/MultiImageEdit.ts

Summary

Maintainability
F
3 days
Test Coverage

Function MultiImageEditController has 209 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function MultiImageEditController(
    $scope: IScope,
    modal,
    notify,
    lock,
Severity: Major
Found in scripts/apps/search/MultiImageEdit.ts - About 1 day to fix

    Function MultiImageEditController has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
    Open

    export function MultiImageEditController(
    $scope: IScope,
    modal,
    notify,
    lock,
    Severity: Minor
    Found in scripts/apps/search/MultiImageEdit.ts - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File MultiImageEdit.ts has 296 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import _ from 'lodash';
import {get} from 'lodash';
import {uniq, pickBy, isEmpty, forEach} from 'lodash';
import {validateMediaFieldsThrows} from 'apps/authoring/authoring/controllers/ChangeImageController';
import {logger} from 'core/services/logger';
    Severity: Minor
    Found in scripts/apps/search/MultiImageEdit.ts - About 3 hrs to fix

      Function MultiImageEditDirective has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function MultiImageEditDirective(asset, $sce) {
    return {
        scope: {
            imagesOriginal: '=',
            isUpload: '=',
      Severity: Minor
      Found in scripts/apps/search/MultiImageEdit.ts - About 1 hr to fix

        Function save has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            $scope.save = (close) => {
        const imagesForSaving = angular.copy($scope.images);

        imagesForSaving.forEach((image) => {
            delete image.selected;
        Severity: Minor
        Found in scripts/apps/search/MultiImageEdit.ts - About 1 hr to fix

          Function MultiImageEditController has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              $scope: IScope,
    modal,
    notify,
    lock,
    session,
          Severity: Minor
          Found in scripts/apps/search/MultiImageEdit.ts - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.selectAll = () => {
        if (Array.isArray($scope.images)) {
            $scope.images.forEach((image) => {
                image.selected = true;
            });
            Severity: Major
            Found in scripts/apps/search/MultiImageEdit.ts and 1 other location - About 1 hr to fix
            scripts/apps/search/MultiImageEdit.ts on lines 78..84

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 67.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.unselectAll = () => {
        if (Array.isArray($scope.images)) {
            $scope.images.forEach((image) => {
                image.selected = false;
            });
            Severity: Major
            Found in scripts/apps/search/MultiImageEdit.ts and 1 other location - About 1 hr to fix
            scripts/apps/search/MultiImageEdit.ts on lines 70..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 67.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    scope: {
            imagesOriginal: '=',
            isUpload: '=',
            saveHandler: '=',
            cancelHandler: '=',
            Severity: Major
            Found in scripts/apps/search/MultiImageEdit.ts and 2 other locations - About 1 hr to fix
            scripts/apps/authoring/authoring/directives/ItemAssociationDirective.ts on lines 27..40
            scripts/core/directives/TypeaheadDirective.ts on lines 37..50

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.areSomeSelected = () =>
        Array.isArray($scope.images) && $scope.images.some((image) => image.selected === true);
            Severity: Minor
            Found in scripts/apps/search/MultiImageEdit.ts and 1 other location - About 55 mins to fix
            scripts/apps/search/MultiImageEdit.ts on lines 86..87

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.areAllSelected = () =>
        Array.isArray($scope.images) && $scope.images.every((image) => image.selected === true);
            Severity: Minor
            Found in scripts/apps/search/MultiImageEdit.ts and 1 other location - About 55 mins to fix
            scripts/apps/search/MultiImageEdit.ts on lines 89..90

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status