Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/search/components/Item.tsx

Summary

Maintainability
D
3 days
Test Coverage

Function render has 194 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const {item} = this.props;
        let classes = this.props.view === 'photogrid' ?
            'sd-grid-item sd-grid-item--with-click' :
            'media-box media-' + item.type;
Severity: Major
Found in scripts/apps/search/components/Item.tsx - About 7 hrs to fix

    File Item.tsx has 431 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* eslint-disable react/no-multi-comp */

import React from 'react';
import classNames from 'classnames';
import {get} from 'lodash';
    Severity: Minor
    Found in scripts/apps/search/components/Item.tsx - About 6 hrs to fix

      Function render has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
      Open

          render() {
        const {item} = this.props;
        let classes = this.props.view === 'photogrid' ?
            'sd-grid-item sd-grid-item--with-click' :
            'media-box media-' + item.type;
      Severity: Minor
      Found in scripts/apps/search/components/Item.tsx - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getTemplate has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              const getTemplate = () => {
            switch (this.props.view) {
            case 'swimlane2':
                return (
                    <ItemSwimlane
      Severity: Major
      Found in scripts/apps/search/components/Item.tsx - About 2 hrs to fix

        Function getNested has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                const getNested = () => {
            switch (this.props.view) {
            case 'swimlane2':
            case 'mgrid':
            case 'photogrid':
        Severity: Minor
        Found in scripts/apps/search/components/Item.tsx - About 1 hr to fix

          Function loadPlanningModals has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              loadPlanningModals() {
        const session = ng.get('session');
        const superdesk = ng.get('superdesk');
        const activityService: IActivityService = ng.get('activityService');
          Severity: Minor
          Found in scripts/apps/search/components/Item.tsx - About 1 hr to fix

            Function loadPlanningModals has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                loadPlanningModals() {
        const session = ng.get('session');
        const superdesk = ng.get('superdesk');
        const activityService: IActivityService = ng.get('activityService');
            Severity: Minor
            Found in scripts/apps/search/components/Item.tsx - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                <ItemSwimlane
                        item={item}
                        itemSelected={itemSelected}
                        isLocked={isLocked}
                        getActionsMenu={getActionsMenu}
            Severity: Minor
            Found in scripts/apps/search/components/Item.tsx and 1 other location - About 45 mins to fix
            scripts/apps/authoring/preview/fullPreviewMultiple.tsx on lines 80..86

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status