Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/search/controllers/SearchMenuController.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function SearchMenuController has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function SearchMenuController(
    $rootScope, $scope, $filter, $location, $route, searchProviderService, api, savedSearch,
    privileges,
) {
    let providerLabels = {};
Severity: Major
Found in scripts/apps/search/controllers/SearchMenuController.ts - About 3 hrs to fix

    Function SearchMenuController has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function SearchMenuController(
    $rootScope, $scope, $filter, $location, $route, searchProviderService, api, savedSearch,
    privileges,
) {
    let providerLabels = {};
    Severity: Minor
    Found in scripts/apps/search/controllers/SearchMenuController.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function SearchMenuController has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        $rootScope, $scope, $filter, $location, $route, searchProviderService, api, savedSearch,
    privileges,
    Severity: Major
    Found in scripts/apps/search/controllers/SearchMenuController.ts - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status