Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/search/controllers/get-multi-actions.tsx

Summary

Maintainability
F
5 days
Test Coverage

Function getMultiActions has 312 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function getMultiActions(
    getSelectedItems: () => Array<IArticle>,
    unselectAll: () => void,
) {
    const $location = ng.get('$location');
Severity: Major
Found in scripts/apps/search/controllers/get-multi-actions.tsx - About 1 day to fix

    File get-multi-actions.tsx has 347 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import _, {flatMap} from 'lodash';
import {IArticle} from 'superdesk-api';
import {gettext} from 'core/utils';

import {IExtensionActivationResult} from 'superdesk-api';
    Severity: Minor
    Found in scripts/apps/search/controllers/get-multi-actions.tsx - About 4 hrs to fix

      Function publish has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const publish = () => {
        const errors = [];

        const addErrorForItem = (item, err) => {
            const itemName = item.headline || item.slugline || item._id;
      Severity: Major
      Found in scripts/apps/search/controllers/get-multi-actions.tsx - About 2 hrs to fix

        Function deschedule has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            const deschedule = () => {
        const descheduled = () => {
            const errors = [];
            const success = [];
        Severity: Minor
        Found in scripts/apps/search/controllers/get-multi-actions.tsx - About 1 hr to fix

          Function descheduled has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  const descheduled = () => {
            const errors = [];
            const success = [];

            Promise.all(
          Severity: Minor
          Found in scripts/apps/search/controllers/get-multi-actions.tsx - About 1 hr to fix

            Function getMultiActions has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

            export function getMultiActions(
    getSelectedItems: () => Array<IArticle>,
    unselectAll: () => void,
) {
    const $location = ng.get('$location');
            Severity: Minor
            Found in scripts/apps/search/controllers/get-multi-actions.tsx - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function spikeItems has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function spikeItems(): void {
        const spikeMultiple = () => {
            Promise.all(
                getSelectedItems().map((item) => sdApi.article.doSpike(item)),
            ).then(() => {
            Severity: Minor
            Found in scripts/apps/search/controllers/get-multi-actions.tsx - About 1 hr to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      const onSpikeMultipleMiddlewares
            : Array<IExtensionActivationResult['contributions']['entities']['article']['onSpikeMultiple']>
            = flatMap(
                Object.values(extensions).map(({activationResult}) => activationResult),
                (activationResult) =>
              Severity: Major
              Found in scripts/apps/search/controllers/get-multi-actions.tsx and 2 other locations - About 6 hrs to fix
              scripts/apps/archive/index.tsx on lines 476..487
              scripts/apps/monitoring/MultiActionBarReact.tsx on lines 29..40

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 169.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              if (errors.length < 1) {
                    notify.success(gettext('All items were published successfully.'));
                    unselectAll();
                } else {
                    errors.forEach((err) => {
              Severity: Major
              Found in scripts/apps/search/controllers/get-multi-actions.tsx and 1 other location - About 5 hrs to fix
              scripts/apps/search/controllers/get-multi-actions.tsx on lines 370..384

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 140.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              if (errors.length === 0) {
                    notify.success(gettext('{{count}} articles have been descheduled', {count: success.length}));
                } else {
                    errors.forEach((err) => {
                        let messages = null;
              Severity: Major
              Found in scripts/apps/search/controllers/get-multi-actions.tsx and 1 other location - About 5 hrs to fix
              scripts/apps/search/controllers/get-multi-actions.tsx on lines 327..342

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 140.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  function duplicateTo() {
        dispatchInternalEvent('interactiveArticleActionStart', {
            items: getSelectedItems(),
            tabs: ['duplicate_to'],
            activeTab: 'duplicate_to',
              Severity: Major
              Found in scripts/apps/search/controllers/get-multi-actions.tsx and 1 other location - About 2 hrs to fix
              scripts/apps/search/controllers/get-multi-actions.tsx on lines 198..210

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 78.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  function unspikeItems() {
        dispatchInternalEvent('interactiveArticleActionStart', {
            items: getSelectedItems(),
            tabs: ['unspike'],
            activeTab: 'unspike',
              Severity: Major
              Found in scripts/apps/search/controllers/get-multi-actions.tsx and 1 other location - About 2 hrs to fix
              scripts/apps/search/controllers/get-multi-actions.tsx on lines 233..245

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 78.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status