Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/search/directives/ItemPreview.ts

Summary

Maintainability
C
1 day
Test Coverage

Function ItemPreview has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function ItemPreview(asset, storage, desks, _, familyService, privileges) {
    /**
     * @description Closes the preview panel if the currently previewed
     * item is spiked / unspiked or moved.
     * @param {Object} scope - angular scope
Severity: Major
Found in scripts/apps/search/directives/ItemPreview.ts - About 4 hrs to fix

    Function link has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            link: function(scope) {
            scope.showRelatedTab = false;
            scope.toggleLeft = JSON.parse(storage.getItem('shiftLeft'));

            /**
    Severity: Major
    Found in scripts/apps/search/directives/ItemPreview.ts - About 3 hrs to fix

      Function ItemPreview has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      export function ItemPreview(asset, storage, desks, _, familyService, privileges) {
    /**
     * @description Closes the preview panel if the currently previewed
     * item is spiked / unspiked or moved.
     * @param {Object} scope - angular scope
      Severity: Minor
      Found in scripts/apps/search/directives/ItemPreview.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ItemPreview has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export function ItemPreview(asset, storage, desks, _, familyService, privileges) {
      Severity: Minor
      Found in scripts/apps/search/directives/ItemPreview.ts - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status