Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/search/directives/SaveSearch.ts

Summary

Maintainability
C
1 day
Test Coverage

Function SaveSearch has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

export function SaveSearch($location, asset, api, notify, $rootScope) {
    return {
        templateUrl: asset.templateUrl('apps/search/views/save-search.html'),
        link: function(scope, _elem) {
            scope.edit = null;
Severity: Minor
Found in scripts/apps/search/directives/SaveSearch.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function SaveSearch has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function SaveSearch($location, asset, api, notify, $rootScope) {
    return {
        templateUrl: asset.templateUrl('apps/search/views/save-search.html'),
        link: function(scope, _elem) {
            scope.edit = null;
Severity: Major
Found in scripts/apps/search/directives/SaveSearch.ts - About 3 hrs to fix

    Function link has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            link: function(scope, _elem) {
            scope.edit = null;
            scope.activateSearchPane = false;

            scope.$on('edit:search', (_event, args) => {
    Severity: Major
    Found in scripts/apps/search/directives/SaveSearch.ts - About 2 hrs to fix

      Function SaveSearch has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export function SaveSearch($location, asset, api, notify, $rootScope) {
      Severity: Minor
      Found in scripts/apps/search/directives/SaveSearch.ts - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status