Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/search/directives/SearchParameters.ts

Summary

Maintainability
F
1 wk
Test Coverage

Function SearchParameters has a Cognitive Complexity of 110 (exceeds 5 allowed). Consider refactoring.
Open

export function SearchParameters($location, asset, tags, metadata, common, desks,
    userList, ingestSources, subscribersService, $templateCache, search) {
    return {
        scope: {
            repo: '=',
Severity: Minor
Found in scripts/apps/search/directives/SearchParameters.ts - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function SearchParameters has 353 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function SearchParameters($location, asset, tags, metadata, common, desks,
    userList, ingestSources, subscribersService, $templateCache, search) {
    return {
        scope: {
            repo: '=',
Severity: Major
Found in scripts/apps/search/directives/SearchParameters.ts - About 1 day to fix

    Function link has 343 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            link: function(scope, elem) {
            const PARAMETERS = getParameters();
            var ENTER = 13;

            scope.dateFilters = getDateFilters()
    Severity: Major
    Found in scripts/apps/search/directives/SearchParameters.ts - About 1 day to fix

      File SearchParameters.ts has 365 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import {getParameters} from 'apps/search/constants';
import {getDateFilters} from './DateFilters';
import _ from 'lodash';

/**
      Severity: Minor
      Found in scripts/apps/search/directives/SearchParameters.ts - About 4 hrs to fix

        Function init has 76 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    function init(loadData?) {
                var params = $location.search();

                scope.query = params.q;
                scope.flags = false;
        Severity: Major
        Found in scripts/apps/search/directives/SearchParameters.ts - About 3 hrs to fix

          Function getQuery has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      function getQuery() {
                var metas = [];
                var pattern = /[()]/g;

                angular.forEach(scope.meta, (val, key) => {
          Severity: Major
          Found in scripts/apps/search/directives/SearchParameters.ts - About 2 hrs to fix

            Function SearchParameters has 11 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            export function SearchParameters($location, asset, tags, metadata, common, desks,
    userList, ingestSources, subscribersService, $templateCache, search) {
            Severity: Major
            Found in scripts/apps/search/directives/SearchParameters.ts - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          function initializeCreators() {
                if ($location.search().original_creator) {
                    scope.fields.original_creator = $location.search().original_creator;
                }
            }
              Severity: Minor
              Found in scripts/apps/search/directives/SearchParameters.ts and 1 other location - About 50 mins to fix
              scripts/apps/search/directives/SearchParameters.ts on lines 250..254

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 52.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          function initializeProviders() {
                if ($location.search().ingest_provider) {
                    scope.fields.ingest_provider = $location.search().ingest_provider;
                }
            }
              Severity: Minor
              Found in scripts/apps/search/directives/SearchParameters.ts and 1 other location - About 50 mins to fix
              scripts/apps/search/directives/SearchParameters.ts on lines 256..260

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 52.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          scope.keyPressed = function(event) {
                if (event.keyCode === ENTER) {
                    searchParameters();
                    event.preventDefault();
                }
              Severity: Minor
              Found in scripts/apps/search/directives/SearchParameters.ts and 1 other location - About 40 mins to fix
              scripts/apps/search/directives/RawSearch.ts on lines 22..27

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status