Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/system-messages/components/system-messages-settings.tsx

Summary

Maintainability
D
1 day
Test Coverage

Function render has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const {item, page} = this.props;
        const formConfig = getFormConfig();

        return (
Severity: Major
Found in scripts/apps/system-messages/components/system-messages-settings.tsx - About 2 hrs to fix

    Function getFormConfig has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getFormConfig(): IFormGroup {
    const formConfig: IFormGroup = {
        type: 'inline',
        direction: 'vertical',
        form: [
    Severity: Minor
    Found in scripts/apps/system-messages/components/system-messages-settings.tsx - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                      <ListItemActionsMenu>
                    <div style={{display: 'flex'}}>
                        <button
                            onClick={(e) => {
                                e.stopPropagation();
      Severity: Major
      Found in scripts/apps/system-messages/components/system-messages-settings.tsx and 2 other locations - About 1 day to fix
      scripts/extensions/broadcasting/src/shows/manage-shows.tsx on lines 81..105
      scripts/extensions/annotationsLibrary/src/annotations-library-page.tsx on lines 62..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 206.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          options: [
                        {id: 'primary', label: getTypeLabel('primary')},
                        {id: 'success', label: getTypeLabel('success')},
                        {id: 'warning', label: getTypeLabel('warning')},
                        {id: 'alert', label: getTypeLabel('alert')},
      Severity: Major
      Found in scripts/apps/system-messages/components/system-messages-settings.tsx and 1 other location - About 1 hr to fix
      scripts/apps/authoring/media/MediaMetadataView.tsx on lines 18..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status