Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/templates/directives/TemplatesDirective.ts

Summary

Maintainability
F
5 days
Test Coverage

Function TemplatesDirective has a Cognitive Complexity of 83 (exceeds 5 allowed). Consider refactoring.
Open

export function TemplatesDirective(notify, api, templates, modal, desks, weekdays, content, $filter, session, _) {
    return {
        templateUrl: 'scripts/apps/templates/views/templates.html',
        link: function($scope) {
            const TEMPLATEFILTERS = getTemplateFilters();
Severity: Minor
Found in scripts/apps/templates/directives/TemplatesDirective.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function TemplatesDirective has 299 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function TemplatesDirective(notify, api, templates, modal, desks, weekdays, content, $filter, session, _) {
    return {
        templateUrl: 'scripts/apps/templates/views/templates.html',
        link: function($scope) {
            const TEMPLATEFILTERS = getTemplateFilters();
Severity: Major
Found in scripts/apps/templates/directives/TemplatesDirective.ts - About 1 day to fix

    Function link has 294 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            link: function($scope) {
            const TEMPLATEFILTERS = getTemplateFilters();

            $scope.weekdays = weekdays;
            $scope.content_templates = null;
    Severity: Major
    Found in scripts/apps/templates/directives/TemplatesDirective.ts - About 1 day to fix

      File TemplatesDirective.ts has 316 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import notifySaveError from '../helpers';
import {gettext} from 'core/utils';
import {getTemplateFilters} from '../constants';
import {dataApi} from 'core/helpers/CrudManager';
import {IArticle} from 'superdesk-api';
      Severity: Minor
      Found in scripts/apps/templates/directives/TemplatesDirective.ts - About 3 hrs to fix

        Function TemplatesDirective has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        export function TemplatesDirective(notify, api, templates, modal, desks, weekdays, content, $filter, session, _) {
        Severity: Major
        Found in scripts/apps/templates/directives/TemplatesDirective.ts - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      $scope.getScheduleDesk = function(template) {
                if (!_.isNil(template)) {
                    let desk = _.find($scope.desks._items, {_id: template.schedule_desk});

                    return desk ? desk.name : null;
          Severity: Major
          Found in scripts/apps/templates/directives/TemplatesDirective.ts and 1 other location - About 2 hrs to fix
          scripts/apps/templates/directives/TemplatesDirective.ts on lines 189..196

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 88.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      $scope.getScheduleStage = function(template) {
                if (!_.isNil(template)) {
                    let stage = _.find(desks.stages._items, {_id: template.schedule_stage});

                    return stage ? stage.name : null;
          Severity: Major
          Found in scripts/apps/templates/directives/TemplatesDirective.ts and 1 other location - About 2 hrs to fix
          scripts/apps/templates/directives/TemplatesDirective.ts on lines 177..184

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 88.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status