Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/users/controllers/ChangeAvatarController.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function ChangeAvatarController has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function ChangeAvatarController($scope, upload, session, urls, beta, notify, _) {
    $scope.methods = [
        {id: 'upload', label: gettext('Upload from computer')},
        {id: 'photo', label: gettext('Take a picture')},
        {id: 'globe', label: gettext('Use a Web URL')},
Severity: Major
Found in scripts/apps/users/controllers/ChangeAvatarController.ts - About 2 hrs to fix

    Function upload has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $scope.upload = function(config) {
        var form: any = {};

        form.CropLeft = Math.round(Math.min(config.cords.x, config.cords.x2));
        form.CropRight = Math.round(Math.max(config.cords.x, config.cords.x2));
    Severity: Minor
    Found in scripts/apps/users/controllers/ChangeAvatarController.ts - About 1 hr to fix

      Function ChangeAvatarController has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export function ChangeAvatarController($scope, upload, session, urls, beta, notify, _) {
      Severity: Major
      Found in scripts/apps/users/controllers/ChangeAvatarController.ts - About 50 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $scope.methods = [
        {id: 'upload', label: gettext('Upload from computer')},
        {id: 'photo', label: gettext('Take a picture')},
        {id: 'globe', label: gettext('Use a Web URL')},
    ];
        Severity: Minor
        Found in scripts/apps/users/controllers/ChangeAvatarController.ts and 1 other location - About 50 mins to fix
        scripts/apps/dashboard/workspace-tasks/tasks.ts on lines 8..12

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                }, (update) => {
            $scope.progress.width = Math.round(update.loaded / update.total * 100.0);
        }));
        Severity: Minor
        Found in scripts/apps/users/controllers/ChangeAvatarController.ts and 1 other location - About 35 mins to fix
        scripts/apps/dictionaries/controllers/DictionaryEditController.ts on lines 45..47

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status