Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/users/controllers/UserListController.ts

Summary

Maintainability
C
1 day
Test Coverage

Function UserListController has 128 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function UserListController($scope, $location, api, _, session, usersService) {
    var DEFAULT_SIZE = 25;

    $scope.selected = {user: null};
    $scope.createdUsers = [];
Severity: Major
Found in scripts/apps/users/controllers/UserListController.ts - About 5 hrs to fix

    Function UserListController has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    export function UserListController($scope, $location, api, _, session, usersService) {
    var DEFAULT_SIZE = 25;

    $scope.selected = {user: null};
    $scope.createdUsers = [];
    Severity: Minor
    Found in scripts/apps/users/controllers/UserListController.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function initCriteria has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function initCriteria(search, filter) {
        const query: any = {};
        const canSeeSupportUsers = usersService.isSupport(session.identity);

        if (!canSeeSupportUsers) {
    Severity: Minor
    Found in scripts/apps/users/controllers/UserListController.ts - About 1 hr to fix

      Function UserListController has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export function UserListController($scope, $location, api, _, session, usersService) {
      Severity: Minor
      Found in scripts/apps/users/controllers/UserListController.ts - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status