Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/users/directives/UserEditDirective.ts

Summary

Maintainability
F
3 days
Test Coverage

Function UserEditDirective has 230 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function UserEditDirective(api, notify, usersService, userList, session, _,
    langmap, $location, $route, superdesk, features, asset, privileges, desks, keyboardManager,
    gettextCatalog, metadata, modal, $q) {
    return {
        templateUrl: asset.templateUrl('apps/users/views/edit-form.html'),
Severity: Major
Found in scripts/apps/users/directives/UserEditDirective.ts - About 1 day to fix

    Function link has 219 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            link: function(scope, elem) {
            // origUser is set by parent scope when selecting users from GUI
            // but it also needs to be updated before editing so dirtiness can be computed correctly
            // according to the latest data on the server
            let clearOrigUserWatcher = noop;
    Severity: Major
    Found in scripts/apps/users/directives/UserEditDirective.ts - About 1 day to fix

      Function UserEditDirective has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
      Open

      export function UserEditDirective(api, notify, usersService, userList, session, _,
    langmap, $location, $route, superdesk, features, asset, privileges, desks, keyboardManager,
    gettextCatalog, metadata, modal, $q) {
    return {
        templateUrl: asset.templateUrl('apps/users/views/edit-form.html'),
      Severity: Minor
      Found in scripts/apps/users/directives/UserEditDirective.ts - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function save has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  scope.save = function() {
                new Promise((resolve) => {
                    if (
                        scope.user._id !== session.identity._id // changing language for another user
                        || scope.user.language === scope.origUser.language
      Severity: Major
      Found in scripts/apps/users/directives/UserEditDirective.ts - About 2 hrs to fix

        Function resetUser has 60 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    function resetUser() {
                clearOrigUserWatcher();
                clearUserWatcher();

                scope.dirty = false;
        Severity: Major
        Found in scripts/apps/users/directives/UserEditDirective.ts - About 2 hrs to fix

          Function UserEditDirective has 19 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          export function UserEditDirective(api, notify, usersService, userList, session, _,
    langmap, $location, $route, superdesk, features, asset, privileges, desks, keyboardManager,
    gettextCatalog, metadata, modal, $q) {
          Severity: Major
          Found in scripts/apps/users/directives/UserEditDirective.ts - About 2 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        scope.goTo = function(id) {
                document.getElementById(id).scrollIntoView({
                    behavior: 'smooth',
                });
            Severity: Minor
            Found in scripts/apps/users/directives/UserEditDirective.ts and 1 other location - About 55 mins to fix
            scripts/apps/users/directives/UserPreferencesDirective.ts on lines 77..83

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status