Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/vocabularies/components/UploadConfigModal.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function UploadConfig has 97 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function UploadConfig(updateVocabulary) {
    return class UploadConfigModal extends React.PureComponent<IProps, IState> {
        constructor(props: IProps) {
            super(props);
Severity: Major
Found in scripts/apps/vocabularies/components/UploadConfigModal.tsx - About 3 hrs to fix

    Function render has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            render() {
            const modalInformationLabel = gettext(`Please be aware that uploading external config files
                will overwrite your existing configuration.`);
            const dropZoneLabel = gettext(`Drag one or more files here to upload them,
                or select files by clicking the button below`);
    Severity: Major
    Found in scripts/apps/vocabularies/components/UploadConfigModal.tsx - About 2 hrs to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              constructor(props: IProps) {
            super(props);

            this.state = {
                files: [],
      Severity: Major
      Found in scripts/apps/vocabularies/components/UploadConfigModal.tsx and 2 other locations - About 2 hrs to fix
      scripts/apps/highlights/components/SetHighlightsForMultipleArticlesModal.tsx on lines 21..30
      scripts/extensions/sams/src/components/common/DesksSelectInput.tsx on lines 34..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 86.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                          canDrop={(event) => {
                                        return event.dataTransfer.items.length > 0 &&
                                            event.dataTransfer.items[0].type.startsWith('application/json');
                                    }}
      Severity: Major
      Found in scripts/apps/vocabularies/components/UploadConfigModal.tsx and 1 other location - About 1 hr to fix
      scripts/apps/authoring/authoring/components/video-thumbnail-editor.tsx on lines 78..80

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status