Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/vocabularies/controllers/VocabularyEditController.tsx

Summary

Maintainability
D
1 day
Test Coverage

Function VocabularyEditController has 166 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function VocabularyEditController(
    $scope: IScope, notify, api, metadata, cvSchema, relationsService, $timeout,
) {
    let componentRef: VocabularyItemsViewEdit = null;
Severity: Major
Found in scripts/apps/vocabularies/controllers/VocabularyEditController.tsx - About 6 hrs to fix

    Function VocabularyEditController has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    export function VocabularyEditController(
    $scope: IScope, notify, api, metadata, cvSchema, relationsService, $timeout,
) {
    let componentRef: VocabularyItemsViewEdit = null;
    Severity: Minor
    Found in scripts/apps/vocabularies/controllers/VocabularyEditController.tsx - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function save has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $scope.save = function() {
        $scope.vocabulary.items = componentRef.getItemsForSaving();
        $scope._errorUniqueness = false;
        $scope.errorMessage = null;
        delete $scope.vocabulary['_deleted'];
    Severity: Minor
    Found in scripts/apps/vocabularies/controllers/VocabularyEditController.tsx - About 1 hr to fix

      Function VocabularyEditController has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          $scope: IScope, notify, api, metadata, cvSchema, relationsService, $timeout,
      Severity: Major
      Found in scripts/apps/vocabularies/controllers/VocabularyEditController.tsx - About 50 mins to fix

        There are no issues that match your filters.

        Category
        Status