Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx

Summary

Maintainability
F
3 days
Test Coverage

File ContentProfileFieldsConfig.tsx has 499 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint-disable react/no-multi-comp */
import React from 'react';
import {
    IPropsGenericFormItemComponent,
    IPropsGenericFormContainer,
Severity: Minor
Found in scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx - About 1 day to fix

    Function render has 121 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
        if (this.state.loading) {
            return null;
        }
    Severity: Major
    Found in scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx - About 4 hrs to fix

      Function render has 89 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          render() {
        const {item, page, index, inEditMode, getId} = this.props.wrapper;
        const {
            sortingInProgress,
            setIndexForNewItem,
      Severity: Major
      Found in scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx - About 3 hrs to fix

        Function componentDidUpdate has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            componentDidUpdate(prevProps: IProps, prevState: IState) {
        if (prevState.fields != null && prevState.fields !== this.state.fields) {
            const editorCopy = {...this.state.editor};
            const schemaCopy = {...this.state.schema};
        Severity: Major
        Found in scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx - About 2 hrs to fix

          Function constructor has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              constructor(props: IProps) {
        super(props);

        this.state = {
            fields: null,
          Severity: Minor
          Found in scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx - About 1 hr to fix

            Function componentDidMount has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                componentDidMount() {
        const vocabularies = ng.get('vocabularies');
        const content = ng.get('content');

        Promise.all([
            Severity: Minor
            Found in scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx - About 1 hr to fix

              Function render has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  render() {
        if (this.state.loading) {
            return null;
        }
              Severity: Minor
              Found in scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function patch has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                          = fieldsFlat.reduce((acc, field, index) => {
                let schemaPatch = {};
                let editorPatch: Partial<IContentProfileEditorConfig[0]> = {};

                acc[field.id] = {
              Severity: Minor
              Found in scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx - About 1 hr to fix

                Function render has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    render() {
        const {item, page, index, inEditMode, getId} = this.props.wrapper;
        const {
            sortingInProgress,
            setIndexForNewItem,
                Severity: Minor
                Found in scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    if (isSchemaKey(_property)) {
                        schemaPatch[_property] = field[_property];

                        if (_property === 'readonly' || _property === 'required') {
                            editorPatch[_property] = field[_property];
                Severity: Minor
                Found in scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx and 1 other location - About 50 mins to fix
                scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx on lines 405..411

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    } else {
                        editorPatch[_property] = field[_property];

                        if (_property === 'minlength' || _property === 'maxlenght') {
                            schemaPatch[_property] = field[_property];
                Severity: Minor
                Found in scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx and 1 other location - About 50 mins to fix
                scripts/apps/workspace/content/components/ContentProfileFieldsConfig.tsx on lines 399..405

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status