Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function getContentProfileFormConfig has 178 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function getContentProfileFormConfig(
    editor: IContentProfileEditorConfig,
    schema: any,
    customFields: Array<any>,
    field?: Partial<IContentProfileFieldWithSystemId> | undefined,
Severity: Major
Found in scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx - About 7 hrs to fix

    File get-content-profiles-form-config.tsx has 279 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {FormFieldType} from 'core/ui/components/generic-form/interfaces/form';
import {
    IFormField,
    IFormGroup,
    IContentProfileEditorConfig,
    Severity: Minor
    Found in scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx - About 2 hrs to fix

      Function getContentProfileFormConfig has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

      export function getContentProfileFormConfig(
    editor: IContentProfileEditorConfig,
    schema: any,
    customFields: Array<any>,
    field?: Partial<IContentProfileFieldWithSystemId> | undefined,
      Severity: Minor
      Found in scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getEditor3RichTextFormattingOptions has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const getEditor3RichTextFormattingOptions = (): {[MEMBER in RICH_FORMATTING_OPTION]: string} => {
    return {
        'h1': gettext('h1'),
        'h2': gettext('h2'),
        'h3': gettext('h3'),
      Severity: Minor
      Found in scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                const maximumLengthField: IFormField = {
            label: gettext('Maximum length'),
            type: FormFieldType.number,
            field: 'maxlength',
            required: false,
        Severity: Major
        Found in scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx and 1 other location - About 1 hr to fix
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 160..168

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                const minimumLengthField: IFormField = {
            label: gettext('Minimum length'),
            type: FormFieldType.number,
            field: 'minlength',
            required: false,
        Severity: Major
        Found in scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx and 1 other location - About 1 hr to fix
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 170..178

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            if (
        field?.id != null
        && (
            schema[field.id].type === 'media'
            || (
        Severity: Major
        Found in scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx and 5 other locations - About 1 hr to fix
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 189..198
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 202..211
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 213..222
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 226..242
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 265..274

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            if (
        field?.id != null
        && characterValidationEnabled
        && (
            schema[field.id]?.type === 'string'
        Severity: Major
        Found in scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx and 5 other locations - About 1 hr to fix
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 189..198
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 202..211
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 213..222
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 265..274
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 276..294

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            if (field?.id != null && customField != null && customField.field_type == null) {
        const showInPreviewField: IFormField = {
            label: gettext('Show in preview'),
            type: FormFieldType.checkbox,
            field: 'preview',
        Severity: Major
        Found in scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx and 5 other locations - About 1 hr to fix
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 189..198
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 213..222
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 226..242
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 265..274
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 276..294

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            if (field?.id != null && field.id === 'feature_media' && schema[field.id].type === 'media') {
        const showCropsField: IFormField = {
            label: gettext('Show Crops'),
            type: FormFieldType.checkbox,
            field: 'showCrops',
        Severity: Major
        Found in scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx and 5 other locations - About 1 hr to fix
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 189..198
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 202..211
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 213..222
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 226..242
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 276..294

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            if (field?.id === 'dateline') {
        const hideDateField: IFormField = {
            label: gettext('Hide Date'),
            type: FormFieldType.checkbox,
            field: 'hideDate',
        Severity: Major
        Found in scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx and 5 other locations - About 1 hr to fix
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 202..211
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 213..222
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 226..242
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 265..274
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 276..294

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            if (field?.id != null && schema[field.id]?.type === 'string') {
        const cleanPastedHtmlField: IFormField = {
            label: gettext('Clean Pasted HTML'),
            type: FormFieldType.checkbox,
            field: 'cleanPastedHTML',
        Severity: Major
        Found in scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx and 5 other locations - About 1 hr to fix
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 189..198
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 202..211
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 226..242
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 265..274
        scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 276..294

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            const showToggle: IFormField = {
        label: gettext('Allow field to be toggled'),
        type: FormFieldType.checkbox,
        field: nameof<ICommonFieldConfig>('allow_toggling'),
        required: false,
        Severity: Major
        Found in scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx and 5 other locations - About 50 mins to fix
        scripts/extensions/broadcasting/src/shows/manage-shows.tsx on lines 24..29
        scripts/extensions/broadcasting/src/shows/manage-shows.tsx on lines 30..35
        scripts/extensions/broadcasting/src/shows/manage-shows.tsx on lines 45..50
        scripts/extensions/predefinedTextField/src/config.tsx on lines 22..27
        scripts/extensions/predefinedTextField/src/config.tsx on lines 29..34

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status