superdesk/superdesk-client-core

View on GitHub
scripts/core/api/api-service.ts

Summary

Maintainability
D
2 days
Test Coverage

Function APIProvider has 211 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function APIProvider() {
    var apis = {};

    /**
     * @ngdoc method
Severity: Major
Found in scripts/core/api/api-service.ts - About 1 day to fix

    Function apiServiceFactory has 202 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function apiServiceFactory($injector, $q, $http, urls, _, HttpEndpointFactory) {
            const CACHE_TTL = 100;
    
            var endpoints = {
                http: HttpEndpointFactory,
    Severity: Major
    Found in scripts/core/api/api-service.ts - About 1 day to fix

      Function APIProvider has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
      Open

      function APIProvider() {
          var apis = {};
      
          /**
           * @ngdoc method
      Severity: Minor
      Found in scripts/core/api/api-service.ts - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function save has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              api.save = function apiSave(resource, dest, diff, parent, params, options?: {skipPostProcessing: boolean}) {
      Severity: Minor
      Found in scripts/core/api/api-service.ts - About 45 mins to fix

        Function apiServiceFactory has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            function apiServiceFactory($injector, $q, $http, urls, _, HttpEndpointFactory) {
        Severity: Minor
        Found in scripts/core/api/api-service.ts - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status