superdesk/superdesk-client-core

View on GitHub
scripts/core/editor3/components/annotations/AnnotationInput.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function render has 105 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        if (this.state.loaded !== true) {
            return null;
        }

Severity: Major
Found in scripts/core/editor3/components/annotations/AnnotationInput.tsx - About 4 hrs to fix

    File AnnotationInput.tsx has 306 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React from 'react';
    import PropTypes from 'prop-types';
    import {Dropdown, NavTabs} from 'core/ui/components';
    import {connect} from 'react-redux';
    
    
    Severity: Minor
    Found in scripts/core/editor3/components/annotations/AnnotationInput.tsx - About 3 hrs to fix

      Function onSubmit has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          onSubmit() {
              const {body, type} = this.state;
              const _hidePopups = this.props.hidePopups;
              const {highlightId} = this.props.data;
      
      
      Severity: Minor
      Found in scripts/core/editor3/components/annotations/AnnotationInput.tsx - About 1 hr to fix

        Function constructor has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            constructor(props) {
                super(props);
        
                const {data, annotationTypes} = props;
                const editing = typeof data.annotation === 'object';
        Severity: Minor
        Found in scripts/core/editor3/components/annotations/AnnotationInput.tsx - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          const AnnotationInputBodyWithDependenciesLoaded = connectPromiseResults(() => ({
              annotationTypes: ng.get('metadata').initialize()
                  .then(() => ng.get('metadata').values.annotation_types),
          }))(AnnotationInputBody);
          scripts/core/editor3/components/annotations/AnnotationPopup.tsx on lines 99..102

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              {annotationTypes.map((annotationType) => (
                                  <option key={annotationType.qcode} value={annotationType.qcode}>
                                      {annotationType.name}
                                  </option>
                              ))}
          scripts/core/ui/components/Form/Select.tsx on lines 25..32

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status