Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/core/editor3/components/links/LinkInput.tsx

Summary

Maintainability
C
7 hrs
Test Coverage

Function renderURL has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    renderURL() {
        return (
            <form
                onSubmit={() => {
                    this.onSubmit(linkTypes.href);
Severity: Minor
Found in scripts/core/editor3/components/links/LinkInput.tsx - About 1 hr to fix

    Function onSubmit has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        onSubmit(linkType) {
        let link;
        const {suggestingMode, localDomains} = this.props;
        const _createLinkSuggestion = this.props.createLinkSuggestion;
        const _applyLink = this.props.applyLink;
    Severity: Minor
    Found in scripts/core/editor3/components/links/LinkInput.tsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function onSubmit has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        onSubmit(linkType) {
        let link;
        const {suggestingMode, localDomains} = this.props;
        const _createLinkSuggestion = this.props.createLinkSuggestion;
        const _applyLink = this.props.applyLink;
    Severity: Minor
    Found in scripts/core/editor3/components/links/LinkInput.tsx - About 1 hr to fix

      Function renderAttachment has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          renderAttachment() {
        return (
            <div>
                <div style={{height: '24rem', overflowY: 'scroll'}}>
                    <AttachmentList
      Severity: Minor
      Found in scripts/core/editor3/components/links/LinkInput.tsx - About 1 hr to fix

        Function constructor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            constructor(props) {
        super(props);

        // when non-null, holds the entity whos URL is being edited
        this.entity = null;
        Severity: Minor
        Found in scripts/core/editor3/components/links/LinkInput.tsx - About 1 hr to fix

          Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              constructor(props) {
        super(props);

        // when non-null, holds the entity whos URL is being edited
        this.entity = null;
          Severity: Minor
          Found in scripts/core/editor3/components/links/LinkInput.tsx - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status