Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/core/keyboard/keyboard.ts

Summary

Maintainability
C
1 day
Test Coverage

File keyboard.ts has 339 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import _ from 'lodash';
import {gettext} from 'core/utils';
import {sdApi} from 'api';

export const KEYS = Object.freeze({
Severity: Minor
Found in scripts/core/keyboard/keyboard.ts - About 4 hrs to fix

    Function bind has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            this.bind = function bind(label, callback, opt) {
            var fct, elt;
            // Initialize options object
            let options = angular.extend({}, defaultOpt, opt);
            let lbl = label.toLowerCase();
    Severity: Major
    Found in scripts/core/keyboard/keyboard.ts - About 2 hrs to fix

      Function KeyEventBroadcast has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function KeyEventBroadcast($rootScope, $document, Keys, shiftNums) {
            var ignoreNodes = {
                INPUT: true,
                TEXTAREA: true,
                BUTTON: true,
      Severity: Minor
      Found in scripts/core/keyboard/keyboard.ts - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const KEYS = Object.freeze({
    pageup: 33,
    pagedown: 34,
    left: 37,
    up: 38,
        Severity: Minor
        Found in scripts/core/keyboard/keyboard.ts and 1 other location - About 50 mins to fix
        scripts/core/ui/components/constants.ts on lines 1..12

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if (e.target) {
                        elem = e.target;
                    } else if (e.srcElement) {
                        elem = e.srcElement;
                    }
        Severity: Minor
        Found in scripts/core/keyboard/keyboard.ts and 1 other location - About 30 mins to fix
        scripts/apps/monitoring/directives/WidgetGroup.ts on lines 338..342

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status