Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/core/notification/notification.ts

Summary

Maintainability
F
3 days
Test Coverage

Function ReloadService has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

function ReloadService($window, $rootScope, session, desks, superdeskFlags) {
    var self = this;

    self.userDesks = [];
    self.result = null;
Severity: Minor
Found in scripts/core/notification/notification.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function WebSocketProxy has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function WebSocketProxy($rootScope, $interval, session, SESSION_EVENTS) {
    var ws = null;
    var connectTimer = -1;
    var TIMEOUT = 5000;
Severity: Major
Found in scripts/core/notification/notification.ts - About 3 hrs to fix

    Function ReloadService has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function ReloadService($window, $rootScope, session, desks, superdeskFlags) {
    var self = this;

    self.userDesks = [];
    self.result = null;
    Severity: Major
    Found in scripts/core/notification/notification.ts - About 3 hrs to fix

      File notification.ts has 269 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /**
* This file is part of Superdesk.
*
* Copyright 2015 Sourcefabric z.u. and contributors.
*
      Severity: Minor
      Found in scripts/core/notification/notification.ts - About 2 hrs to fix

        Function bindEvents has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            var bindEvents = function() {
        ws.onmessage = function(event) {
            var msg = angular.fromJson(event.data);

            // Delay all websocket events to avoid getting old data.
        Severity: Minor
        Found in scripts/core/notification/notification.ts - About 1 hr to fix

          Function reloadIdentifier has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              this.reloadIdentifier = function(msg) {
        var result = {
            reload: false,
            message: null,
        };
          Severity: Minor
          Found in scripts/core/notification/notification.ts - About 1 hr to fix

            Function onmessage has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    ws.onmessage = function(event) {
            var msg = angular.fromJson(event.data);

            // Delay all websocket events to avoid getting old data.
            // The server is sending websocket events before it is able to return updated data.
            Severity: Minor
            Found in scripts/core/notification/notification.ts - About 1 hr to fix

              Function ReloadService has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function ReloadService($window, $rootScope, session, desks, superdeskFlags) {
              Severity: Minor
              Found in scripts/core/notification/notification.ts - About 35 mins to fix

                Function WebSocketProxy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                function WebSocketProxy($rootScope, $interval, session, SESSION_EVENTS) {
    var ws = null;
    var connectTimer = -1;
    var TIMEOUT = 5000;
                Severity: Minor
                Found in scripts/core/notification/notification.ts - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export function addInternalWebsocketEventListener<T extends keyof IInternalWebsocketMessages>(
    event: T,
    handler: (message: IInternalWebsocketMessages[T]) => void,
): () => void {
    const eventName = getInternalWebsocketMessageEventName(event);
                Severity: Major
                Found in scripts/core/notification/notification.ts and 1 other location - About 4 hrs to fix
                scripts/core/notification/notification.ts on lines 65..75

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 123.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export function addWebsocketEventListener<T extends keyof IPublicWebsocketMessages>(
    event: T,
    handler: (message: IPublicWebsocketMessages[T]) => void,
): () => void {
    const eventName = getWebsocketMessageEventName(event);
                Severity: Major
                Found in scripts/core/notification/notification.ts and 1 other location - About 4 hrs to fix
                scripts/core/notification/notification.ts on lines 77..87

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 123.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status