Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/extensions/broadcasting/src/rundown-templates/manage-rundown-templates.tsx

Summary

Maintainability
F
3 days
Test Coverage

Function render has 270 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const {template, showId} = this.state;

        const viewEditToolbar = template == null || template.type === 'create' ? null : (
            <WithLiveResources
Severity: Major
Found in scripts/extensions/broadcasting/src/rundown-templates/manage-rundown-templates.tsx - About 1 day to fix

    File manage-rundown-templates.tsx has 407 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import * as React from 'react';
import {
    Button,
    IconButton,
    Tooltip,
    Severity: Minor
    Found in scripts/extensions/broadcasting/src/rundown-templates/manage-rundown-templates.tsx - About 5 hrs to fix

      Function constructor has 83 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          constructor(props: IProps) {
        super(props);

        this.state = {
            showId: props.initialShow?.id ?? null,
      Severity: Major
      Found in scripts/extensions/broadcasting/src/rundown-templates/manage-rundown-templates.tsx - About 3 hrs to fix

        Function itemTemplate has 75 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                this.itemTemplate = (templateProps) => {
            const template = templateProps.entity;

            const actions: Array<IMenuItem> = [
                {
        Severity: Major
        Found in scripts/extensions/broadcasting/src/rundown-templates/manage-rundown-templates.tsx - About 3 hrs to fix

          Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              constructor(props: IProps) {
        super(props);

        this.state = {
            showId: props.initialShow?.id ?? null,
          Severity: Minor
          Found in scripts/extensions/broadcasting/src/rundown-templates/manage-rundown-templates.tsx - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                                      {
                                                gettext('Modified at {{time}} by {{user}}', {
                                                    time: () => <DateTime dateTime={template.value._updated} />,
                                                    user: () => <strong>{userUpdater.display_name}</strong>,
                                                })
          Severity: Major
          Found in scripts/extensions/broadcasting/src/rundown-templates/manage-rundown-templates.tsx and 1 other location - About 1 hr to fix
          scripts/extensions/broadcasting/src/rundown-templates/manage-rundown-templates.tsx on lines 164..169

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                      {
                                gettext('Created at {{time}} by {{user}}', {
                                    time: () => <DateTime dateTime={template.value._created} />,
                                    user: () => <strong>{userCreator.display_name}</strong>,
                                })
          Severity: Major
          Found in scripts/extensions/broadcasting/src/rundown-templates/manage-rundown-templates.tsx and 1 other location - About 1 hr to fix
          scripts/extensions/broadcasting/src/rundown-templates/manage-rundown-templates.tsx on lines 181..186

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              const userCreator = users._items.find(({_id}) => _id === template.value.created_by) as IUser;
          Severity: Minor
          Found in scripts/extensions/broadcasting/src/rundown-templates/manage-rundown-templates.tsx and 1 other location - About 35 mins to fix
          scripts/extensions/broadcasting/src/rundown-templates/manage-rundown-templates.tsx on lines 173..175

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                              const userUpdater = users._items.find(
                                        ({_id}) => _id === template.value.updated_by,
                                    ) as IUser;
          Severity: Minor
          Found in scripts/extensions/broadcasting/src/rundown-templates/manage-rundown-templates.tsx and 1 other location - About 35 mins to fix
          scripts/extensions/broadcasting/src/rundown-templates/manage-rundown-templates.tsx on lines 160..160

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status