superdesk/superdesk-client-core

View on GitHub
scripts/extensions/broadcasting/src/rundown-templates/template-edit.tsx

Summary

Maintainability
F
3 days
Test Coverage

Function render has 342 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const {templateFields, readOnly} = this.props;

        const headline_template = this.props.templateFields.title_template ?? {
            prefix: '',

    File template-edit.tsx has 537 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import * as React from 'react';
    import * as Layout from 'superdesk-ui-framework/react/components/Layouts';
    import {isEqual} from 'lodash';
    import {
        Input,

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                                          const actions: Array<ITopBarWidget<IRundownItemTemplateInitial>> = [
                                                              {
                                                                  availableOffline: true,
                                                                  group: 'start',
                                                                  priority: 0.1,
      scripts/extensions/broadcasting/src/rundowns/rundown-view-edit.tsx on lines 593..608

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 91.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      export interface IEdit extends IWithAuthoringReactKey {
          type: 'edit';
          item: IRundownItemTemplateInitial;
          authoringStorage: IAuthoringStorage<IRundownItemTemplateInitial>;
      }
      scripts/extensions/broadcasting/src/rundown-templates/template-edit.tsx on lines 59..63
      scripts/extensions/broadcasting/src/rundown-templates/template-edit.tsx on lines 71..75

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      export interface ICreate extends IWithAuthoringReactKey {
          type: 'create';
          item: IRundownItemTemplateInitial;
          authoringStorage: IAuthoringStorage<IRundownItemTemplateInitial>;
      }
      scripts/extensions/broadcasting/src/rundown-templates/template-edit.tsx on lines 65..69
      scripts/extensions/broadcasting/src/rundown-templates/template-edit.tsx on lines 71..75

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      export interface IPreview extends IWithAuthoringReactKey {
          type: 'preview';
          item: IRundownItemTemplateInitial;
          authoringStorage: IAuthoringStorage<IRundownItemTemplateInitial>;
      }
      scripts/extensions/broadcasting/src/rundown-templates/template-edit.tsx on lines 59..63
      scripts/extensions/broadcasting/src/rundown-templates/template-edit.tsx on lines 65..69

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status