Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/extensions/broadcasting/src/rundowns/rundown-view-edit.tsx

Summary

Maintainability
F
4 days
Test Coverage

Function render has 390 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const rundown = this.state.rundownWithChanges;
        const lockedInOtherSession = rundown == null ? true : isLockedInOtherSession(rundown);
        const editingDisallowed = lockedInOtherSession || this.props.readOnly;
Severity: Major
Found in scripts/extensions/broadcasting/src/rundowns/rundown-view-edit.tsx - About 1 day to fix

    File rundown-view-edit.tsx has 681 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* eslint-disable react/no-multi-comp */

import * as React from 'react';
import {
    IRundown,
    Severity: Major
    Found in scripts/extensions/broadcasting/src/rundowns/rundown-view-edit.tsx - About 1 day to fix

      Function initiateCreation has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          initiateCreation(
        rundownId: IRundown['_id'],
        initialData: Partial<IRundownItemBase>,
        insertAtIndex?: number,
        skipUnsavedChangesCheck?: boolean,
      Severity: Minor
      Found in scripts/extensions/broadcasting/src/rundowns/rundown-view-edit.tsx - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        function handleUnsavedRundownChanges(
    mode: IRundownItemActionNext,
    skipUnsavedChangesCheck: boolean,
    onSuccess: () => void,
) {
        Severity: Major
        Found in scripts/extensions/broadcasting/src/rundowns/rundown-view-edit.tsx and 1 other location - About 3 hrs to fix
        scripts/extensions/broadcasting/src/utils/handle-unsaved-rundown-changes.ts on lines 7..29

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 111.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                                            const actions: Array<ITopBarWidget<IRundownItem>> = [
                                                        {
                                                            availableOffline: true,
                                                            group: 'start',
                                                            priority: 0.1,
        Severity: Major
        Found in scripts/extensions/broadcasting/src/rundowns/rundown-view-edit.tsx and 1 other location - About 2 hrs to fix
        scripts/extensions/broadcasting/src/rundown-templates/template-edit.tsx on lines 537..552

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 91.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (!isEqual(rundown, this.state.rundownWithChanges)) {
            superdesk.ui.confirm(gettext('Discard unsaved changes?')).then((confirmed) => {
                if (confirmed) {
                    this.props.onClose(rundown);
                }
        Severity: Major
        Found in scripts/extensions/broadcasting/src/rundowns/rundown-view-edit.tsx and 1 other location - About 1 hr to fix
        scripts/extensions/broadcasting/src/rundowns/manage-rundown-items.tsx on lines 117..124

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                copy.items = items.map((item) => {
            const itemCopy = {...item};

            if (item.duration == null) {
                item.duration = item.planned_duration;
        Severity: Minor
        Found in scripts/extensions/broadcasting/src/rundowns/rundown-view-edit.tsx and 1 other location - About 40 mins to fix
        scripts/extensions/broadcasting/src/rundowns/rundown-view-edit.tsx on lines 129..137

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export function prepareRundownItemForSaving(item: Partial<IRundownItemBase>): Partial<IRundownItemBase> {
    const copy = {...item};

    if (item.duration == null) {
        item.duration = item.planned_duration;
        Severity: Minor
        Found in scripts/extensions/broadcasting/src/rundowns/rundown-view-edit.tsx and 1 other location - About 40 mins to fix
        scripts/extensions/broadcasting/src/rundowns/rundown-view-edit.tsx on lines 115..123

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status