Sign upLogin

superdesk/superdesk-client-core

View on GitHub
Star
scripts/extensions/broadcasting/src/shows/manage-shows.tsx

Summary

Maintainability
D
1 day
Test Coverage

Function render has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        class ItemComponent extends React.PureComponent<IPropsGenericFormItemComponent<IShow>> {
            render() {
                const {item, page} = this.props;
Severity: Minor
Found in scripts/extensions/broadcasting/src/shows/manage-shows.tsx - About 1 hr to fix

    Function render has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                render() {
                const {item, page} = this.props;

                return (
                    <ListItem onClick={() => page.openPreview(item._id)}>
    Severity: Minor
    Found in scripts/extensions/broadcasting/src/shows/manage-shows.tsx - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                              <ListItemActionsMenu>
                            <div style={{display: 'flex'}}>
                                <button
                                    onClick={(e) => {
                                        e.stopPropagation();
      Severity: Major
      Found in scripts/extensions/broadcasting/src/shows/manage-shows.tsx and 2 other locations - About 1 day to fix
      scripts/apps/system-messages/components/system-messages-settings.tsx on lines 110..134
      scripts/extensions/annotationsLibrary/src/annotations-library-page.tsx on lines 62..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 206.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

      const shortCode: IFormField = {
    label: gettext('Show code'),
    type: FormFieldType.plainText,
    field: nameof<IShow>('shortcode'),
    required: false,
      Severity: Major
      Found in scripts/extensions/broadcasting/src/shows/manage-shows.tsx and 5 other locations - About 50 mins to fix
      scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 296..301
      scripts/extensions/broadcasting/src/shows/manage-shows.tsx on lines 24..29
      scripts/extensions/broadcasting/src/shows/manage-shows.tsx on lines 45..50
      scripts/extensions/predefinedTextField/src/config.tsx on lines 22..27
      scripts/extensions/predefinedTextField/src/config.tsx on lines 29..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

      const plannedDurationField: IFormField = {
    label: gettext('Planned duration'),
    type: FormFieldType.duration,
    field: nameof<IShow>('planned_duration'),
    required: true,
      Severity: Major
      Found in scripts/extensions/broadcasting/src/shows/manage-shows.tsx and 5 other locations - About 50 mins to fix
      scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 296..301
      scripts/extensions/broadcasting/src/shows/manage-shows.tsx on lines 24..29
      scripts/extensions/broadcasting/src/shows/manage-shows.tsx on lines 30..35
      scripts/extensions/predefinedTextField/src/config.tsx on lines 22..27
      scripts/extensions/predefinedTextField/src/config.tsx on lines 29..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

      const nameField: IFormField = {
    label: gettext('Show name'),
    type: FormFieldType.plainText,
    field: nameof<IShow>('title'),
    required: true,
      Severity: Major
      Found in scripts/extensions/broadcasting/src/shows/manage-shows.tsx and 5 other locations - About 50 mins to fix
      scripts/apps/workspace/content/components/get-content-profiles-form-config.tsx on lines 296..301
      scripts/extensions/broadcasting/src/shows/manage-shows.tsx on lines 30..35
      scripts/extensions/broadcasting/src/shows/manage-shows.tsx on lines 45..50
      scripts/extensions/predefinedTextField/src/config.tsx on lines 22..27
      scripts/extensions/predefinedTextField/src/config.tsx on lines 29..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status