superdesk/superdesk-client-core

View on GitHub
scripts/extensions/videoEditor/src/VideoEditor.tsx

Summary

Maintainability
F
4 days
Test Coverage

File VideoEditor.tsx has 666 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as React from 'react';
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
import ReactCrop from 'react-image-crop';
import 'react-image-crop/dist/ReactCrop.css';
Severity: Major
Found in scripts/extensions/videoEditor/src/VideoEditor.tsx - About 1 day to fix

    Function render has 136 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
            const {gettext} = this.props.superdesk.localization;
            const {getClass} = this.props.superdesk.utilities.CSS;
            const degree = this.state.transformations.degree + 'deg';
            const videoRef = this.videoRef.current;
    Severity: Major
    Found in scripts/extensions/videoEditor/src/VideoEditor.tsx - About 5 hrs to fix

      VideoEditor has 27 functions (exceeds 20 allowed). Consider refactoring.
      Open

      export class VideoEditor extends React.Component<IProps, IState> {
          private videoRef: React.RefObject<HTMLVideoElement>;
          private reactCropRef: React.RefObject<ReactCrop>;
          private reactCropInitImage: string;
          private intervalThumbnails: number;
      Severity: Minor
      Found in scripts/extensions/videoEditor/src/VideoEditor.tsx - About 3 hrs to fix

        Function getCropRotate has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            getCropRotate(crop: ICrop): ICrop {
                if (this.videoRef.current == null) {
                    throw new Error('Could not get rotated video crop value');
                }
        
        
        Severity: Minor
        Found in scripts/extensions/videoEditor/src/VideoEditor.tsx - About 1 hr to fix

          Function handleSave has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              handleSave() {
                  const {dataApi} = this.props.superdesk;
                  const {gettext} = this.props.superdesk.localization;
                  const {x, y, width, height} = this.state.transformations.crop;
                  const crop = this.getCropRotate({x: x, y: y, width: width, height: height});
          Severity: Minor
          Found in scripts/extensions/videoEditor/src/VideoEditor.tsx - About 1 hr to fix

            Function constructor has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                constructor(props: IProps) {
                    super(props);
                    this.videoRef = React.createRef();
                    this.reactCropRef = React.createRef();
                    this.intervalThumbnails = 0;
            Severity: Minor
            Found in scripts/extensions/videoEditor/src/VideoEditor.tsx - About 1 hr to fix

              Function handleCheckingVideo has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  handleCheckingVideo(resetState: boolean = true, callback?: () => void) {
                      this.intervalCheckVideo = window.setInterval(() => {
                          this.props.superdesk.dataApi
                              .findOne<IVideoProject>('video_edit', this.state.article._id)
                              .then((result) => {
              Severity: Minor
              Found in scripts/extensions/videoEditor/src/VideoEditor.tsx - About 1 hr to fix

                Function handleRotateTransitionEnd has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    handleRotateTransitionEnd() {
                        // avoid transition rerun after set scale
                        if (this.hasTransitionRun === true || this.videoRef.current == null) {
                            return;
                        }
                Severity: Minor
                Found in scripts/extensions/videoEditor/src/VideoEditor.tsx - About 1 hr to fix

                  Function intervalCheckVideo has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          this.intervalCheckVideo = window.setInterval(() => {
                              this.props.superdesk.dataApi
                                  .findOne<IVideoProject>('video_edit', this.state.article._id)
                                  .then((result) => {
                                      const processing = result.project.processing;
                  Severity: Minor
                  Found in scripts/extensions/videoEditor/src/VideoEditor.tsx - About 1 hr to fix

                    Function handleRotateTransitionEnd has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        handleRotateTransitionEnd() {
                            // avoid transition rerun after set scale
                            if (this.hasTransitionRun === true || this.videoRef.current == null) {
                                return;
                            }
                    Severity: Minor
                    Found in scripts/extensions/videoEditor/src/VideoEditor.tsx - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function handleCheckingVideo has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        handleCheckingVideo(resetState: boolean = true, callback?: () => void) {
                            this.intervalCheckVideo = window.setInterval(() => {
                                this.props.superdesk.dataApi
                                    .findOne<IVideoProject>('video_edit', this.state.article._id)
                                    .then((result) => {
                    Severity: Minor
                    Found in scripts/extensions/videoEditor/src/VideoEditor.tsx - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function render has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        render() {
                            const {gettext} = this.props.superdesk.localization;
                            const {getClass} = this.props.superdesk.utilities.CSS;
                            const degree = this.state.transformations.degree + 'deg';
                            const videoRef = this.videoRef.current;
                    Severity: Minor
                    Found in scripts/extensions/videoEditor/src/VideoEditor.tsx - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function handleSave has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        handleSave() {
                            const {dataApi} = this.props.superdesk;
                            const {gettext} = this.props.superdesk.localization;
                            const {x, y, width, height} = this.state.transformations.crop;
                            const crop = this.getCropRotate({x: x, y: y, width: width, height: height});
                    Severity: Minor
                    Found in scripts/extensions/videoEditor/src/VideoEditor.tsx - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    .create('video_edit', {
                                        edit: body,
                                        item: {
                                            _id: this.state.article._id,
                                            renditions: this.state.article.renditions,
                    Severity: Minor
                    Found in scripts/extensions/videoEditor/src/VideoEditor.tsx and 1 other location - About 35 mins to fix
                    scripts/extensions/videoEditor/src/VideoEditorThumbnail.tsx on lines 165..171

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status