Sign upLogin

supermarin/xcpretty

View on GitHub
Star

Showing 12 of 12 total issues

Class Simple has 37 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Simple < Formatter

    PASS = "✓"
    FAIL = "✗"
    PENDING = "⧖"
Severity: Minor
Found in lib/xcpretty/formatters/simple.rb - About 4 hrs to fix

    Method parse has 119 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def parse(text)
      update_test_state(text)
      update_error_state(text)
      update_linker_failure_state(text)
    Severity: Major
    Found in lib/xcpretty/parser.rb - About 4 hrs to fix

      File parser.rb has 339 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      module XCPretty

  module Matchers

    # @regex Captured groups
      Severity: Minor
      Found in lib/xcpretty/parser.rb - About 4 hrs to fix

        Method status_symbol has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            def status_symbol(status)
      case status
      when :pass
        green(use_unicode? ? PASS : ASCII_PASS)
      when :fail
        Severity: Minor
        Found in lib/xcpretty/formatters/simple.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Class Parser has 22 methods (exceeds 20 allowed). Consider refactoring.
        Open

          class Parser

    include Matchers
    include Matchers::Errors
    include Matchers::Warnings
        Severity: Minor
        Found in lib/xcpretty/parser.rb - About 2 hrs to fix

          Method format_compile_warning has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def format_compile_warning(file, file_path, reason, line, cursor)
          Severity: Minor
          Found in lib/xcpretty/formatters/formatter.rb - About 35 mins to fix

            Method format_compile_error has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def format_compile_error(file, file_path, reason, line, cursor)
            Severity: Minor
            Found in lib/xcpretty/formatters/formatter.rb - About 35 mins to fix

              Method format_compile_error has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def format_compile_error(file_name, file_path, reason,
                             line, cursor);                    EMPTY; end
              Severity: Minor
              Found in lib/xcpretty/formatters/formatter.rb - About 35 mins to fix

                Method format_compile_warning has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def format_compile_warning(file_name, file_path, reason,
                               line, cursor);                  EMPTY; end
                Severity: Minor
                Found in lib/xcpretty/formatters/formatter.rb - About 35 mins to fix

                  Method load_screenshots has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def load_screenshots
      Dir.foreach(SCREENSHOT_DIR) do |item|
        next if item == '.' || item == '..' || File.extname(item) != '.png'

        test = find_test(item)
                  Severity: Minor
                  Found in lib/xcpretty/reporters/html.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      def format_compile_warning
      warning = current_issue.dup
      @current_issue = {}
      @formatting_warning = false
      formatter.format_compile_warning(warning[:file_name],
                  Severity: Minor
                  Found in lib/xcpretty/parser.rb and 1 other location - About 15 mins to fix
                  lib/xcpretty/parser.rb on lines 520..528

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 26.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      def format_compile_error
      error = current_issue.dup
      @current_issue = {}
      @formatting_error = false
      formatter.format_compile_error(error[:file_name],
                  Severity: Minor
                  Found in lib/xcpretty/parser.rb and 1 other location - About 15 mins to fix
                  lib/xcpretty/parser.rb on lines 531..539

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 26.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language