Sign upLogin

supherman/dustbag

View on GitHub
Star
lib/dustbag/parser/map_collection_node.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use each_with_object instead of inject.
Open

        @collection ||= members.inject({}) do |acc, val|
Severity: Minor
Found in lib/dustbag/parser/map_collection_node.rb by rubocop

This cop looks for inject / reduce calls where the passed in object is returned at the end and so could be replaced by eachwithobject without the need to return the object at the end.

However, we can't replace with eachwithobject if the accumulator parameter is assigned to within the block.

Example:

# bad
[1, 2].inject({}) { |a, e| a[e] = e; a }

# good
[1, 2].each_with_object({}) { |e, a| a[e] = e }

Missing top-level module documentation comment.
Open

    module MapCollectionNode
Severity: Minor
Found in lib/dustbag/parser/map_collection_node.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

There are no issues that match your filters.

Category
Status