Sign upLogin

swaggest/json-schema-maker

View on GitHub
Star

Showing 28 of 28 total issues

Function makeValue has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

    public function makeValue()
    {
        if (isset($this->schema->{'example'})) {
            return $this->schema->{'example'};
        }
Severity: Minor
Found in src/InstanceFaker.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addType has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    private function addType($type)
    {
        if ($type === Schema::NULL) {
            if ($this->options->useNullable) {
                $this->schema->{'nullable'} = true;
Severity: Minor
Found in src/SchemaMaker.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addObject has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    private function addObject($instanceValue, $path)
    {
        if (null === $this->schema->properties) {
            $this->schema->setFromRef($this->options->defsPtr . JsonPointer::escapeSegment(ltrim($path, '.')));
            $this->schema->properties = new Properties();
Severity: Minor
Found in src/SchemaMaker.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method makeValue has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function makeValue()
    {
        if (isset($this->schema->{'example'})) {
            return $this->schema->{'example'};
        }
Severity: Major
Found in src/InstanceFaker.php - About 3 hrs to fix

    Function makeObject has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        private function makeObject()
    {
        $result = new \stdClass();
        if ($this->schema->properties !== null) {
            foreach ($this->schema->getProperties() as $propertyName => $property) {
    Severity: Minor
    Found in src/InstanceFaker.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function makeArray has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        private function makeArray()
    {
        $numItems = 1;
        if ($this->schema->minItems !== null && $numItems < $this->schema->minItems) {
            $numItems = $this->schema->minItems;
    Severity: Minor
    Found in src/InstanceFaker.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method addObject has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function addObject($instanceValue, $path)
    {
        if (null === $this->schema->properties) {
            $this->schema->setFromRef($this->options->defsPtr . JsonPointer::escapeSegment(ltrim($path, '.')));
            $this->schema->properties = new Properties();
    Severity: Major
    Found in src/SchemaMaker.php - About 2 hrs to fix

      Method addType has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function addType($type)
    {
        if ($type === Schema::NULL) {
            if ($this->options->useNullable) {
                $this->schema->{'nullable'} = true;
      Severity: Minor
      Found in src/SchemaMaker.php - About 1 hr to fix

        Function addInstanceValue has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function addInstanceValue($instanceValue, $path = '')
    {
        $passes = 1;
        if ($this->options->heuristicRequired && empty($path)) {
            // Two passes are needed for heuristic required population to ensure missing properties in first samples
        Severity: Minor
        Found in src/SchemaMaker.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method addInstanceValue has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function addInstanceValue($instanceValue, $path = '')
    {
        $passes = 1;
        if ($this->options->heuristicRequired && empty($path)) {
            // Two passes are needed for heuristic required population to ensure missing properties in first samples
        Severity: Minor
        Found in src/SchemaMaker.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (isset($this->schema->allOf)) {
            foreach ($this->schema->allOf as $i => $schema) {
                if ($schema instanceof Wrapper) {
                    $schema = $schema->exportSchema();
                }
          Severity: Minor
          Found in src/InstanceFaker.php and 1 other location - About 45 mins to fix
          src/InstanceFaker.php on lines 87..99

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 96.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (isset($this->schema->anyOf)) {
            foreach ($this->schema->anyOf as $i => $schema) {
                if ($schema instanceof Wrapper) {
                    $schema = $schema->exportSchema();
                }
          Severity: Minor
          Found in src/InstanceFaker.php and 1 other location - About 45 mins to fix
          src/InstanceFaker.php on lines 73..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 96.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function makeString has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function makeString()
    {
        if ($this->schema->format === Format::DATE_TIME) {
            return "2006-01-02T15:04:05Z";
        }
          Severity: Minor
          Found in src/InstanceFaker.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                          return $val;
          Severity: Major
          Found in src/InstanceFaker.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                    return $val;
            Severity: Major
            Found in src/InstanceFaker.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                      return $val;
              Severity: Major
              Found in src/InstanceFaker.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return round($this->makeNumber());
                Severity: Major
                Found in src/InstanceFaker.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return $this->makeArray();
                  Severity: Major
                  Found in src/InstanceFaker.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return true;
                    Severity: Major
                    Found in src/InstanceFaker.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return $this->makeObject();
                      Severity: Major
                      Found in src/InstanceFaker.php - About 30 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language