Sign upLogin

swaggest/php-code-builder

View on GitHub
Star
src/JsonSchema/SchemaBuilder.php

Summary

Maintainability
F
4 days
Test Coverage

File SchemaBuilder.php has 450 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Swaggest\PhpCodeBuilder\JsonSchema;
Severity: Minor
Found in src/JsonSchema/SchemaBuilder.php - About 6 hrs to fix

    Function processOther has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        private function processOther()
    {
        static $skip = null, $emptySchema = null, $names = null;
        if ($skip === null) {
            $emptySchema = new Schema();
    Severity: Minor
    Found in src/JsonSchema/SchemaBuilder.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function processLogic has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        private function processLogic()
    {
        $names = Schema::names();
        /** @var string $keyword */
        foreach (array($names->not, $names->if, $names->then, $names->else) as $keyword) {
    Severity: Minor
    Found in src/JsonSchema/SchemaBuilder.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method processOther has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function processOther()
    {
        static $skip = null, $emptySchema = null, $names = null;
        if ($skip === null) {
            $emptySchema = new Schema();
    Severity: Major
    Found in src/JsonSchema/SchemaBuilder.php - About 2 hrs to fix

      Method processType has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function processType()
    {
        if ($this->schema->type !== null) {
            switch ($this->schema->type) {
                case Type::INTEGER:
      Severity: Major
      Found in src/JsonSchema/SchemaBuilder.php - About 2 hrs to fix

        Function processEnum has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            private function processEnum()
    {
        if (!empty($this->schema->enum)) {
            $this->result->addSnippet(
                "{$this->varName}->enum = array(\n"
        Severity: Minor
        Found in src/JsonSchema/SchemaBuilder.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method processLogic has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function processLogic()
    {
        $names = Schema::names();
        /** @var string $keyword */
        foreach (array($names->not, $names->if, $names->then, $names->else) as $keyword) {
        Severity: Major
        Found in src/JsonSchema/SchemaBuilder.php - About 2 hrs to fix

          Function processType has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

              private function processType()
    {
        if ($this->schema->type !== null) {
            switch ($this->schema->type) {
                case Type::INTEGER:
          Severity: Minor
          Found in src/JsonSchema/SchemaBuilder.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method processObject has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function processObject()
    {
        if ($this->schema->type === Type::OBJECT) {
            if (!$this->skipProperties) {
                $this->result->addSnippet(
          Severity: Minor
          Found in src/JsonSchema/SchemaBuilder.php - About 1 hr to fix

            Function processObject has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                private function processObject()
    {
        if ($this->schema->type === Type::OBJECT) {
            if (!$this->skipProperties) {
                $this->result->addSnippet(
            Severity: Minor
            Found in src/JsonSchema/SchemaBuilder.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method processEnum has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function processEnum()
    {
        if (!empty($this->schema->enum)) {
            $this->result->addSnippet(
                "{$this->varName}->enum = array(\n"
            Severity: Minor
            Found in src/JsonSchema/SchemaBuilder.php - About 1 hr to fix

              Method processArray has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function processArray()
    {
        $schema = $this->schema;

        if (is_bool($schema->additionalItems)) {
              Severity: Minor
              Found in src/JsonSchema/SchemaBuilder.php - About 1 hr to fix

                Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function __construct($schema, $varName, $path, PhpBuilder $phpBuilder, $createVarName = true)
                Severity: Minor
                Found in src/JsonSchema/SchemaBuilder.php - About 35 mins to fix

                  Function processFromRef has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function processFromRef()
    {
        if ($this->phpBuilder->minimizeRefs) {
            if ($fromRefs = $this->schema->getFromRefs()) {
                $fromRef = $fromRefs[count($fromRefs) - 1];
                  Severity: Minor
                  Found in src/JsonSchema/SchemaBuilder.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (!$this->skipProperties
            //&& $this->schema->type === Type::OBJECT
            && !$this->phpBuilder->minimizeRefs
            && $this->schema->getFromRefs()
        ) {
                  Severity: Major
                  Found in src/JsonSchema/SchemaBuilder.php and 1 other location - About 2 hrs to fix
                  src/JsonSchema/SchemaBuilder.php on lines 133..150

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 127.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (!$this->skipProperties
            //&& $this->schema->type === Type::OBJECT
            && $this->schema->properties !== null
        ) {
            $class = $this->phpBuilder->getClass($this->schema, $this->path);
                  Severity: Major
                  Found in src/JsonSchema/SchemaBuilder.php and 1 other location - About 2 hrs to fix
                  src/JsonSchema/SchemaBuilder.php on lines 156..174

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 127.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status