Sign upLogin

swimlane/ngx-charts

View on GitHub
Star
projects/swimlane/ngx-charts/src/lib/number-card/card-series.component.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function update has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  update(): void {
    if (this.data.length > 2) {
      const valueFormatting = this.valueFormatting || (card => card.value.toLocaleString());

      const sortedLengths = this.data
Severity: Minor
Found in projects/swimlane/ngx-charts/src/lib/number-card/card-series.component.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getCards has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  getCards(): CardModel[] {
    const yPadding =
      typeof this.innerPadding === 'number' ? this.innerPadding : this.innerPadding[0] + this.innerPadding[2];
    const xPadding =
      typeof this.innerPadding === 'number' ? this.innerPadding : this.innerPadding[1] + this.innerPadding[3];
Severity: Minor
Found in projects/swimlane/ngx-charts/src/lib/number-card/card-series.component.ts - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

        if (this.data.length > 2) {
      const valueFormatting = this.valueFormatting || (card => card.value.toLocaleString());

      const sortedLengths = this.data
        .map(d => {
    Severity: Major
    Found in projects/swimlane/ngx-charts/src/lib/number-card/card-series.component.ts - About 40 mins to fix

      There are no issues that match your filters.

      Category
      Status