swimlane/ngx-datatable

View on GitHub
projects/swimlane/ngx-datatable/src/lib/utils/sort.ts

Summary

Maintainability
C
1 day
Test Coverage

Function orderByComparator has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

export function orderByComparator(a: any, b: any): number {
  if (a === null || typeof a === 'undefined') a = 0;
  if (b === null || typeof b === 'undefined') b = 0;
  if (a instanceof Date && b instanceof Date) {
    if (a < b) return -1;
Severity: Minor
Found in projects/swimlane/ngx-datatable/src/lib/utils/sort.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function sortRows has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function sortRows(rows: any[], columns: any[], dirs: SortPropDir[]): any[] {
  if (!rows) return [];
  if (!dirs || !dirs.length || !columns) return [...rows];

  /**
Severity: Minor
Found in projects/swimlane/ngx-datatable/src/lib/utils/sort.ts - About 1 hr to fix

    Function nextSortDir has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export function nextSortDir(sortType: SortType, current: SortDirection): SortDirection | undefined {
      if (sortType === SortType.single) {
        if (current === SortDirection.asc) {
          return SortDirection.desc;
        } else {
    Severity: Minor
    Found in projects/swimlane/ngx-datatable/src/lib/utils/sort.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sortRows has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    export function sortRows(rows: any[], columns: any[], dirs: SortPropDir[]): any[] {
      if (!rows) return [];
      if (!dirs || !dirs.length || !columns) return [...rows];
    
      /**
    Severity: Minor
    Found in projects/swimlane/ngx-datatable/src/lib/utils/sort.ts - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        if (parseFloat(a) < parseFloat(b)) return -1;
    Severity: Major
    Found in projects/swimlane/ngx-datatable/src/lib/utils/sort.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return 0;
      Severity: Major
      Found in projects/swimlane/ngx-datatable/src/lib/utils/sort.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return undefined;
        Severity: Major
        Found in projects/swimlane/ngx-datatable/src/lib/utils/sort.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              if (parseFloat(a) > parseFloat(b)) return 1;
          Severity: Major
          Found in projects/swimlane/ngx-datatable/src/lib/utils/sort.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return undefined;
            Severity: Major
            Found in projects/swimlane/ngx-datatable/src/lib/utils/sort.ts - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status