Sign upLogin

swimlane/ngx-datatable

View on GitHub
Star
src/app/basic/row-grouping.component.ts

Summary

Maintainability
C
1 day
Test Coverage

Function checkGroup has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

  checkGroup(event, row, rowIndex, group) {
    let groupStatus = 'Pending';
    let expectedPaymentDealtWith = true;

    row.exppayyes = 0;
Severity: Minor
Found in src/app/basic/row-grouping.component.ts - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkGroup has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  checkGroup(event, row, rowIndex, group) {
    let groupStatus = 'Pending';
    let expectedPaymentDealtWith = true;

    row.exppayyes = 0;
Severity: Major
Found in src/app/basic/row-grouping.component.ts - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

        if (
      group.filter(rowFilter => rowFilter.exppaypending === 1).length === 0 &&
      group.filter(rowFilter => rowFilter.exppaypending === 0 && rowFilter.exppayyes === 0 && rowFilter.exppayno === 0)
        .length === 0
    ) {
    Severity: Major
    Found in src/app/basic/row-grouping.component.ts - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                  if (group[index].exppayyes === 0 && group[index].exppayno === 0 && group[index].exppaypending === 0) {
              expectedPaymentDealtWith = false;
            }
      Severity: Major
      Found in src/app/basic/row-grouping.component.ts - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                    if (group[index].source !== row.source) {
              if (event.target.value === '0') {
                // expected payment yes selected
                group[index].exppayyes = 0;
                group[index].exppaypending = 0;
        Severity: Major
        Found in src/app/basic/row-grouping.component.ts - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status