Sign upLogin

swimlane/ngx-ui

View on GitHub
Star
projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts

Summary

Maintainability
C
1 day
Test Coverage

SelectDropdownComponent has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

@Component({
  exportAs: 'ngxSelectDropdown',
  selector: 'ngx-select-dropdown',
  templateUrl: './select-dropdown.component.html',
  host: {
Severity: Minor
Found in projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts - About 3 hrs to fix

    File select-dropdown.component.ts has 260 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { coerceNumberProperty } from '@angular/cdk/coercion';
import {
  AfterViewInit,
  ChangeDetectionStrategy,
  ChangeDetectorRef,
    Severity: Minor
    Found in projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts - About 2 hrs to fix

      Function calculateGroups has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private calculateGroups(groupBy: string, options: any[], filter?: string): any[] {
    if (!options) return [];

    const filterOptions = { filterCaseSensitive: this.filterCaseSensitive };
      Severity: Minor
      Found in projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts - About 1 hr to fix

        Function calculateGroups has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          private calculateGroups(groupBy: string, options: any[], filter?: string): any[] {
    if (!options) return [];

    const filterOptions = { filterCaseSensitive: this.filterCaseSensitive };
        Severity: Minor
        Found in projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function focusNext has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          focusNext() {
    const options = this.options;
    const len = options.length;
    if (this.focusIndex < len - 1) {
      for (let i = this.focusIndex + 1; i < len; i++) {
        Severity: Minor
        Found in projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function focusPrev has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          focusPrev() {
    const options = this.options;
    if (this.focusIndex > 0) {
      for (let i = this.focusIndex - 1; i >= 0; i--) {
        if (!options[i].disabled && !options[i].hidden) {
        Severity: Minor
        Found in projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              case KeyboardKeys.ENTER:
        // Enter may trigger dropdown close
        return this.isSelected(option) ? this.deselection.emit(option) : this.selection.emit(option);
        Severity: Minor
        Found in projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts and 1 other location - About 50 mins to fix
        projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts on lines 208..210

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              case KeyboardKeys.SPACE:
        // Space does not trigger dropdown close
        return this.isSelected(option) ? this.keyboardDeselection.emit(option) : this.keyboardSelection.emit(option);
        Severity: Minor
        Found in projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts and 1 other location - About 50 mins to fix
        projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts on lines 205..207

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        @Component({
  exportAs: 'ngxSelectDropdown',
  selector: 'ngx-select-dropdown',
  templateUrl: './select-dropdown.component.html',
  host: {
        Severity: Minor
        Found in projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts and 1 other location - About 40 mins to fix
        projects/swimlane/ngx-ui/src/lib/components/select/select-input.component.ts on lines 19..299

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              for (let i = this.focusIndex - 1; i >= 0; i--) {
        if (!options[i].disabled && !options[i].hidden) {
          this.focusIndex = i;
          break;
        }
        Severity: Minor
        Found in projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts and 1 other location - About 35 mins to fix
        projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts on lines 218..223

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              for (let i = this.focusIndex + 1; i < len; i++) {
        if (!options[i].disabled && !options[i].hidden) {
          this.focusIndex = i;
          break;
        }
        Severity: Minor
        Found in projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts and 1 other location - About 35 mins to fix
        projects/swimlane/ngx-ui/src/lib/components/select/select-dropdown.component.ts on lines 230..235

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status