Sign upLogin

swimlane/swimlane-python

View on GitHub
Star
functional_tests/driver_tests/test_app_revision_adaptor.py

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @pytest.mark.xfail(reason="SPT-6038: URL is being made with the string, throwing errors")
    def test_app_get_invalid_revision(helpers):
        theapp = pytest.swimlane_instance.apps.get(id=pytest.appid)
        with pytest.raises(ValueError) as excinfo:
            theapp.revisions.get('garbage')
Severity: Major
Found in functional_tests/driver_tests/test_app_revision_adaptor.py and 1 other location - About 4 hrs to fix
functional_tests/driver_tests/test_app_revision_adaptor.py on lines 58..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @pytest.mark.xfail(reason="SPT-6038?: Attribute error 'list' object has no attribute 'get'")
    def test_app_get_empty_revision(helpers):
        theapp = pytest.swimlane_instance.apps.get(id=pytest.appid)
        with pytest.raises(ValueError) as excinfo:
            theapp.revisions.get('')
Severity: Major
Found in functional_tests/driver_tests/test_app_revision_adaptor.py and 1 other location - About 4 hrs to fix
functional_tests/driver_tests/test_app_revision_adaptor.py on lines 43..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def test_app_get_negative_number_revision(helpers):
        theapp = pytest.swimlane_instance.apps.get(id=pytest.appid)
        with pytest.raises(ValueError) as excinfo:
            theapp.revisions.get(-2)
        assert str(excinfo.value) == pytest.py_ver_no_json()
Severity: Major
Found in functional_tests/driver_tests/test_app_revision_adaptor.py and 1 other location - About 3 hrs to fix
functional_tests/driver_tests/test_app_revision_adaptor.py on lines 37..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def test_app_get_too_large_number_revision(helpers):
        theapp = pytest.swimlane_instance.apps.get(id=pytest.appid)
        with pytest.raises(ValueError) as excinfo:
            theapp.revisions.get(99)
        assert str(excinfo.value) == pytest.py_ver_no_json()
Severity: Major
Found in functional_tests/driver_tests/test_app_revision_adaptor.py and 1 other location - About 3 hrs to fix
functional_tests/driver_tests/test_app_revision_adaptor.py on lines 31..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status