Sign upLogin

swipely/docker-api

View on GitHub
Star
lib/docker/connection.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method request has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def request(*args, &block)
    retries ||= 0
    request = compile_request_params(*args, &block)
    log_request(request)
    begin
Severity: Minor
Found in lib/docker/connection.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method request has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def request(*args, &block)
    retries ||= 0
    request = compile_request_params(*args, &block)
    log_request(request)
    begin
Severity: Minor
Found in lib/docker/connection.rb - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                Docker.logger.warn(
              <<~RETRY_WARNING
              Automatically retrying with content type '#{response_cause}'
                Original Error: #{ex}
              RETRY_WARNING
    Severity: Major
    Found in lib/docker/connection.rb - About 45 mins to fix

      Method compile_request_params has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def compile_request_params(http_method, path, query = nil, opts = nil, &block)
      Severity: Minor
      Found in lib/docker/connection.rb - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status