Sign upLogin

sylvaindethier/nvm-test

View on GitHub
Star

Showing 5 of 5 total issues

Function handler has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const handler = (argv) => {
  // get versions from argv._
  const versions = argv._
  // get options
  const { install, test, dryRun, logLevel } = argv
Severity: Minor
Found in src/command.js - About 1 hr to fix

    Function hookable has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    export function hookable (fn) {
  if (!isFunction(fn)) throw new TypeError('Argument must be a function')

  /**
   * {@link Hookable} function
    Severity: Minor
    Found in src/api/hooks.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      { install = config.install, test = config.test, dryRun = config.dryRun } = {},
    Severity: Minor
    Found in src/api/nvm-test-version.js and 1 other location - About 35 mins to fix
    src/api/nvm-test-versions.js on lines 20..20

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      { install = config.install, test = config.test, dryRun = config.dryRun } = {},
    Severity: Minor
    Found in src/api/nvm-test-versions.js and 1 other location - About 35 mins to fix
    src/api/nvm-test-version.js on lines 22..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Redundant use of await on a return value.
    Open

      return await nvmTest(version, { test, dryRun }, nvmTestHooks)
    Severity: Minor
    Found in src/api/nvm-test-version.js by eslint

    Disallows unnecessary return await (no-return-await)

    Inside an async function, return await is useless. Since the return value of an async function is always wrapped in Promise.resolve, return await doesn't actually do anything except add extra time before the overarching Promise resolves or rejects. This pattern is almost certainly due to programmer ignorance of the return semantics of async functions.

    Rule Details

    This rule aims to prevent a likely common performance hazard due to a lack of understanding of the semantics of async function.

    The following patterns are considered warnings:

    async function foo() {
  return await bar();
}

    The following patterns are not warnings:

    async function foo() {
  return bar();
}

async function foo() {
  await bar();
  return;
}

async function foo() {
  const x = await bar();
  return x;
}

    When Not To Use It

    If you want to use await to denote a value that is a thenable, even when it is not necessary; or if you do not want the performance benefit of avoiding return await, you can turn off this rule.

    Further Reading

    async function on MDN Source: http://eslint.org/docs/rules/

    Severity
    Category
    Status
    Source
    Language