Sign upLogin

symfony-doge/veslo

View on GitHub
Star

Showing 47 of 47 total issues

Function execute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute(PitInterface $source, int $iterations): int
    {
        $iterationRemains = max(1, $iterations);
        $iterationSuccess = 0;
        $iterationClosure = $this->iteration;
Severity: Minor
Found in src/AppBundle/Workflow/Vacancy/Worker/Iteration/Loop.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        LoggerInterface $logger,
        VacancyRepository $vacancyRepository,
        AnalyserInterface $vacancyAnalyser,
        IndexCreator $sanityIndexCreator,
        NormalizerInterface $sanityIndexNormalizer
Severity: Minor
Found in src/SanityBundle/Vacancy/Indexer/Cockroach.php - About 35 mins to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            EngineInterface $templateEngine,
        Journal $vacancyJournal,
        Archive $vacancyArchive,
        IndexRepository $indexRepository,
        TranslatorInterface $translator
    Severity: Minor
    Found in src/AnthillBundle/Controller/VacancyController.php - About 35 mins to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              LoggerInterface $logger,
        NormalizerInterface $normalizer,
        DecisionInterface $decision,
        Creator $vacancyCreator,
        PitInterface $destination
      Severity: Minor
      Found in src/AnthillBundle/Vacancy/Collector/AntWorker.php - About 35 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                ClientInterface $motClient,
        CredentialsStorageInterface $credentialsStorage,
        DataConverter $dataConverter,
        AdapterInterface $cache,
        array $options
        Severity: Minor
        Found in src/SanityBundle/Vacancy/Tag/Group/Provider/MinistryOfTruth.php - About 35 mins to fix

          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  LoggerInterface $logger,
        Workflow $workflow,
        Serializer $serializer,
        Client $amqpClient,
        string $queuePrefix
          Severity: Minor
          Found in src/AppBundle/Workflow/Vacancy/Research/Conveyor.php - About 35 mins to fix

            Function resolveUrl has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private function resolveUrl(array $response, ?string $cacheKey = null): string
    {
        // Symfony PropertyAccessor is not used due to unnecessary dependency overload.
        // This strategy requires only two fields to analyse: found count and url.
        if (!empty($response['items'])) {
            Severity: Minor
            Found in src/AnthillBundle/Vacancy/Roadmap/Strategy/HeadHunter/Api/Version20190213.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language