symphonycms/symphony-2

View on GitHub

Showing 714 of 844 total issues

File content.blueprintssections.php has 666 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * @package content
 */

Severity: Major
Found in symphony/content/content.blueprintssections.php - About 1 day to fix

    File content.systemauthors.php has 646 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    /**
     * @package content
     */
    Severity: Major
    Found in symphony/content/content.systemauthors.php - About 1 day to fix

      File class.database.php has 643 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      
      /**
       * @package toolkit
       */
      Severity: Major
      Found in symphony/lib/toolkit/class.database.php - About 1 day to fix

        File field.upload.php has 630 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        
        /**
         * @package toolkit
         */
        Severity: Major
        Found in symphony/lib/toolkit/fields/field.upload.php - About 1 day to fix

          File content.blueprintspages.php has 614 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          
          /**
           * @package content
           */
          Severity: Major
          Found in symphony/content/content.blueprintspages.php - About 1 day to fix

            File class.extensionmanager.php has 606 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            /**
             * @package toolkit
             */
            Severity: Major
            Found in symphony/lib/toolkit/class.extensionmanager.php - About 1 day to fix

              File backend.views.js has 604 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              /**
               * Symphony backend views
               *
               * @package assets
               */
              Severity: Major
              Found in symphony/assets/js/src/backend.views.js - About 1 day to fix

                Function generate has a Cognitive Complexity of 66 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function generate(array &$param_pool = null)
                    {
                        $result = new XMLElement($this->dsParamROOTELEMENT);
                        $this->_param_pool = $param_pool;
                        $requiresPagination = (!isset($this->dsParamPAGINATERESULTS) ||
                Severity: Minor
                Found in symphony/lib/toolkit/data-sources/class.datasource.section.php - About 1 day to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method __form has 256 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function __form($readonly = false)
                    {
                        $formHasErrors = (is_array($this->_errors) && !empty($this->_errors));
                
                        if ($formHasErrors) {
                Severity: Major
                Found in symphony/content/content.blueprintsevents.php - About 1 day to fix

                  Method __form has 239 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function __form()
                      {
                          // Handle unknown context
                          if (!in_array($this->_context['action'], array('new', 'edit'))) {
                              Administration::instance()->errorPageNotFound();
                  Severity: Major
                  Found in symphony/content/content.systemauthors.php - About 1 day to fix

                    Database has 65 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    class Database
                    {
                        /**
                         * Constant to indicate whether the query is a write operation.
                         *
                    Severity: Major
                    Found in symphony/lib/toolkit/class.database.php - About 1 day to fix

                      Method prepareAssociationsDrawer has 234 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private function prepareAssociationsDrawer($section)
                          {
                              $entry_id = (!is_null($this->_context['entry_id'])) ? $this->_context['entry_id'] : null;
                              $show_entries = Symphony::Configuration()->get('association_maximum_rows', 'symphony');
                      
                      
                      Severity: Major
                      Found in symphony/content/content.publish.php - About 1 day to fix

                        File field.date.php has 555 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php
                        
                        /**
                         * @package toolkit
                         */
                        Severity: Major
                        Found in symphony/lib/toolkit/fields/field.date.php - About 1 day to fix

                          Method __formAction has 233 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function __formAction()
                              {
                                  $fields = $_POST['fields'];
                                  $this->_errors = array();
                                  $providers = Symphony::ExtensionManager()->getProvidersOf(iProvider::DATASOURCE);
                          Severity: Major
                          Found in symphony/content/content.blueprintsdatasources.php - About 1 day to fix

                            Method __viewEdit has 233 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function __viewEdit()
                                {
                                    $this->setPageType('form');
                                    $fields = array("title"=>null, "handle"=>null, "parent"=>null, "params"=>null, "type"=>null, "data_sources"=>null);
                                    $existing = $fields;
                            Severity: Major
                            Found in symphony/content/content.blueprintspages.php - About 1 day to fix

                              Function install has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  private function install()
                                  {
                                      $db = null;
                                      $fields = $this->extendDatabaseFields(self::$POST['fields']);
                                      $start = time();
                              Severity: Minor
                              Found in install/lib/class.installer.php - About 1 day to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              File class.installer.php has 535 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              <?php
                              
                              /**
                               * @package install
                               */
                              Severity: Major
                              Found in install/lib/class.installer.php - About 1 day to fix

                                File field.taglist.php has 526 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                <?php
                                /**
                                 * @package toolkit
                                 */
                                
                                
                                Severity: Major
                                Found in symphony/lib/toolkit/fields/field.taglist.php - About 1 day to fix

                                  Method install has 215 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      private function install()
                                      {
                                          $db = null;
                                          $fields = $this->extendDatabaseFields(self::$POST['fields']);
                                          $start = time();
                                  Severity: Major
                                  Found in install/lib/class.installer.php - About 1 day to fix

                                    Function __viewIndex has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        public function __viewIndex()
                                        {
                                            $canonical_link = '/system/extensions/';
                                            $this->setPageType('table');
                                            $this->setTitle(__('%1$s &ndash; %2$s', array(__('Extensions'), __('Symphony'))));
                                    Severity: Minor
                                    Found in symphony/content/content.systemextensions.php - About 1 day to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language