Sign upLogin

symphonycms/symphony-2

View on GitHub
Star
symphony/assets/js/src/symphony.duplicator.js

Summary

Maintainability
D
2 days
Test Coverage

Function symphonyDuplicator has 200 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $.fn.symphonyDuplicator = function(options) {
        var objects = this,
            settings = {
                instances: '> li:not(.template)',
                templates: '> li.template',
Severity: Major
Found in symphony/assets/js/src/symphony.duplicator.js - About 1 day to fix

    Function duplicators has 177 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            objects.each(function duplicators() {
            var duplicator = $(this),
                list = duplicator.find('> ol'),
                apply = $('<fieldset class="apply" />'),
                selector = $('<select />'),
    Severity: Major
    Found in symphony/assets/js/src/symphony.duplicator.js - About 7 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  duplicator.on('destructstart.duplicator', '.instance', function unlockConstructor() {
                if(duplicator.find('.instance').length <= settings.maximum) {
                    constructor.removeClass('disabled');
                }
            });
      Severity: Major
      Found in symphony/assets/js/src/symphony.duplicator.js and 1 other location - About 1 hr to fix
      symphony/assets/js/src/symphony.duplicator.js on lines 153..157

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  duplicator.on('constructstop.duplicator', '.instance', function lockConstructor() {
                if(duplicator.find('.instance').length >= settings.maximum) {
                    constructor.addClass('disabled');
                }
            });
      Severity: Major
      Found in symphony/assets/js/src/symphony.duplicator.js and 1 other location - About 1 hr to fix
      symphony/assets/js/src/symphony.duplicator.js on lines 160..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status