Sign upLogin

symplely/coroutine

View on GitHub
Star
Coroutine/Misc/TaskGroup.php

Summary

Maintainability
C
1 day
Test Coverage

Function join has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

  public function join()
  {
    $coroutine = \coroutine();
    try {
      // We wait for no-one. Tasks get cancelled on return.
Severity: Minor
Found in Coroutine/Misc/TaskGroup.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File TaskGroup.php has 275 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Async\Misc;
Severity: Minor
Found in Coroutine/Misc/TaskGroup.php - About 2 hrs to fix

    Method join has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public function join()
  {
    $coroutine = \coroutine();
    try {
      // We wait for no-one. Tasks get cancelled on return.
    Severity: Major
    Found in Coroutine/Misc/TaskGroup.php - About 2 hrs to fix

      Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        public function __construct(array $tasks = [], string $wait = 'all')
  {
    $coroutine = \coroutine();
    $this->wait = $wait;
    foreach ($tasks as $tid) {
      Severity: Minor
      Found in Coroutine/Misc/TaskGroup.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __invoke has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        public function __invoke()
  {
    if (!$this->withSet) {
      yield $this->withSet();
    }
      Severity: Minor
      Found in Coroutine/Misc/TaskGroup.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function add_task has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        public function add_task(int $tid)
  {
    $coroutine = \coroutine();
    $task = $coroutine->getTask($tid);
    if ($task instanceof TaskInterface && $task->hasGroup()) {
      Severity: Minor
      Found in Coroutine/Misc/TaskGroup.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status